opendev/gerrit
Code Issues Proposed changes

Switch to java 8

Browse Source 
Official support for Java 7 was discontinued on April 2015: [1].

[1] https://www.java.com/en/download/faq/java_7.xml

Change-Id: I3aaf3eba118aaec3114a6dce8e93eda9dff4a18d
This commit is contained in:
David Ostrovsky
2019-03-29 00:25:10 +01:00
committed by David Pursehouse
parent 6bc00e1688
commit 407ae56d25
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.buckconfig
View File

@@ -20,6 +20,8 @@
[java] [java]
jar_spool_mode = direct_to_jar jar_spool_mode = direct_to_jar
src_roots = java, resources, src src_roots = java, resources, src
source_level = 8
target_level = 8
[project] [project]
ignore = .git, eclipse-out, bazel-gerrit, bin ignore = .git, eclipse-out, bazel-gerrit, bin

2
Documentation/dev-buck.txt
View File

@@ -3,7 +3,7 @@
== Installation == Installation
You need to use Java 7 and Node.js for building gerrit. You need to use Java 8 and Node.js for building gerrit.
There is currently no binary distribution of Buck, so it has to be manually There is currently no binary distribution of Buck, so it has to be manually
built and installed. Apache Ant and gcc are required. Currently only Linux built and installed. Apache Ant and gcc are required. Currently only Linux

4
gerrit-main/src/main/java/Main.java
View File

@@ -31,11 +31,11 @@ public final class Main {
private static boolean onSupportedJavaVersion() { private static boolean onSupportedJavaVersion() {
final String version = System.getProperty("java.specification.version"); final String version = System.getProperty("java.specification.version");
if (1.7 <= parse(version)) { if (1.8 <= parse(version)) {
return true; return true;
} }
System.err.println("fatal: Gerrit Code Review requires Java 7 or later"); System.err.println("fatal: Gerrit Code Review requires Java 8 or later");
System.err.println(" (trying to run on Java " + version + ")"); System.err.println(" (trying to run on Java " + version + ")");
return false; return false;
} }