opendev/gerrit
Code Issues Proposed changes

Merge "Remove unnecessary 'return' statements"

Browse Source
This commit is contained in:
Shawn Pearce
2013-11-18 03:51:15 +00:00
committed by Gerrit Code Review
parent 5c96817e31 cc2bccfdfd
commit 40b526ae33
7 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java
View File

@@ -57,12 +57,10 @@ public class SideBySideTable extends AbstractPatchContentTable {
protected void createFileCommentEditorOnSideA() {
createCommentEditor(R_HEAD + 1, A, R_HEAD, FILE_SIDE_A);
return;
}
protected void createFileCommentEditorOnSideB() {
createCommentEditor(R_HEAD + 1, B, R_HEAD, FILE_SIDE_B);
return;
}
@Override

11
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedDiffTable.java
View File

@@ -90,11 +90,8 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
if (idSideA != null && idSideA.equals(psId)) {
rowOfTableHeaderB++;
borderRowOfFileComment++;
return;
}
if (idSideB.equals(psId)) {
} else if (idSideB.equals(psId)) {
borderRowOfFileComment++;
return;
}
}
}
@@ -137,11 +134,8 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
if (idSideA != null && idSideA.equals(psId)) {
rowOfTableHeaderB--;
borderRowOfFileComment--;
return;
}
if (idSideB.equals(psId)) {
} else if (idSideB.equals(psId)) {
borderRowOfFileComment--;
return;
}
}
}
@@ -171,7 +165,6 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
protected void createFileCommentEditorOnSideA() {
createCommentEditor(R_HEAD + 1, PC, R_HEAD, FILE_SIDE_A);
return;
}
protected void createFileCommentEditorOnSideB() {