opendev/gerrit
Code Issues Proposed changes

Add extension API to get/set default diff preferences

Browse Source 
Change-Id: Ia2c4e9516b16e79a18c7e4d84911ef548eb1d1c5
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2016-06-03 13:52:06 +02:00
parent 3a663b6caa
commit 41655df2b5
3 changed files with 63 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/config/DiffPreferencesIT.java
View File

@@ -18,18 +18,20 @@ import static com.google.common.truth.Truth.assertThat;
import static com.google.gerrit.server.config.ConfigUtil.skipField;
import com.google.gerrit.acceptance.AbstractDaemonTest;
import com.google.gerrit.acceptance.RestResponse;
import com.google.gerrit.acceptance.NoHttpd;
import com.google.gerrit.extensions.client.DiffPreferencesInfo;
import org.junit.Test;
import java.lang.reflect.Field;
@NoHttpd
public class DiffPreferencesIT extends AbstractDaemonTest {
@Test
public void getDiffPreferences() throws Exception {
DiffPreferencesInfo result = get();
DiffPreferencesInfo result =
gApi.config().server().getDefaultDiffPreferences();
assertPrefsEqual(result, DiffPreferencesInfo.defaults());
}
@@ -38,28 +40,16 @@ public class DiffPreferencesIT extends AbstractDaemonTest {
int newLineLength = DiffPreferencesInfo.defaults().lineLength + 10;
DiffPreferencesInfo update = new DiffPreferencesInfo();
update.lineLength = newLineLength;
DiffPreferencesInfo result = put(update);
DiffPreferencesInfo result =
gApi.config().server().setDefaultDiffPreferences(update);
assertThat(result.lineLength).named("lineLength").isEqualTo(newLineLength);
result = get();
result = gApi.config().server().getDefaultDiffPreferences();
DiffPreferencesInfo expected = DiffPreferencesInfo.defaults();
expected.lineLength = newLineLength;
assertPrefsEqual(result, expected);
}
private DiffPreferencesInfo get() throws Exception {
RestResponse r = adminRestSession.get("/config/server/preferences.diff");
r.assertOK();
return newGson().fromJson(r.getReader(), DiffPreferencesInfo.class);
}
private DiffPreferencesInfo put(DiffPreferencesInfo input) throws Exception {
RestResponse r = adminRestSession.put(
"/config/server/preferences.diff", input);
r.assertOK();
return newGson().fromJson(r.getReader(), DiffPreferencesInfo.class);
}
private void assertPrefsEqual(DiffPreferencesInfo actual,
DiffPreferencesInfo expected) throws Exception {
for (Field field : actual.getClass().getDeclaredFields()) {