opendev/gerrit
Code Issues Proposed changes

ReviewInput: Remove unused strictLabels attribute

Browse Source 
Change-Id: If37864289dbdc17e2f6c04297d32bb2a38074b5a
This commit is contained in:
David Ostrovsky
2018-04-05 23:00:03 +02:00
parent 15dc942823
commit 41af3c57c7
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/changes/ReviewInput.java
View File

@@ -35,15 +35,6 @@ public class ReviewInput {
public Map<String, List<CommentInput>> comments; public Map<String, List<CommentInput>> comments;
public Map<String, List<RobotCommentInput>> robotComments; public Map<String, List<RobotCommentInput>> robotComments;
/**
* If true require all labels to be within the user's permitted ranges based on access controls,
* attempting to use a label not granted to the user will fail the entire modify operation early.
* If false the operation will execute anyway, but the proposed labels given by the user will be
* modified to be the "best" value allowed by the access controls, or ignored if the label does
* not exist.
*/
public boolean strictLabels = true;
/** /**
* How to process draft comments already in the database that were not also described in this * How to process draft comments already in the database that were not also described in this
* input request. * input request.
@@ -66,8 +57,6 @@ public class ReviewInput {
* on behalf of this named user instead of the caller. Caller must have the labelAs-$NAME * on behalf of this named user instead of the caller. Caller must have the labelAs-$NAME
* permission granted for each label that appears in {@link #labels}. This is in addition to the * permission granted for each label that appears in {@link #labels}. This is in addition to the
* named user also needing to have permission to use the labels. * named user also needing to have permission to use the labels.
*
* <p>{@link #strictLabels} impacts how labels is processed for the named user, not the caller.
*/ */
public String onBehalfOf; public String onBehalfOf;