opendev/gerrit
Code Issues Proposed changes

Refactor: Make static methods in SystemGroupBackend non-static

Browse Source 
In a follow-up change we want to make the names of the system groups
configurable. This means we need to get GerritServerConfig injected
into SystemGroupBackend and use the configured system group names when
we create the GroupReference's.

For the callers this means that SystemGroupBackend must be injected
now.

Change-Id: Ia50ea0cd2837c3518a3c6ed84d4612606ccaa8a3
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-01-19 18:01:28 +01:00
parent 97f74f081d
commit 42686d785c
21 changed files with 88 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/AbstractDaemonTest.java
View File

@@ -83,6 +83,7 @@ import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.git.MetaDataUpdate;
import com.google.gerrit.server.git.ProjectConfig;
import com.google.gerrit.server.group.SystemGroupBackend;
import com.google.gerrit.server.index.change.ChangeIndex;
import com.google.gerrit.server.index.change.ChangeIndexCollection;
import com.google.gerrit.server.index.change.ChangeIndexer;
@@ -245,6 +246,9 @@ public abstract class AbstractDaemonTest {
@Inject
protected ChangeResource.Factory changeResourceFactory;
@Inject
protected SystemGroupBackend systemGroupBackend;
@Inject
private EventRecorder.Factory eventRecorderFactory;