opendev/gerrit
Code Issues Proposed changes

Remove ::content and fix the no-left style for shift + a

Browse Source 
added gr-hovercard test back, increased the transition time
for css animation to avoid opacity flaky.

Bug: Issue 11177
Change-Id: I51e4f0f39b4f558619bde660eb0ce9d30076b37e
(cherry picked from commit f8db27703c)
This commit is contained in:
Tao Zhou
2019-10-22 12:48:19 +02:00
committed by Paladox none
parent e0ebf9d3e5
commit 42ee197041
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
View File

@@ -31,10 +31,10 @@ limitations under the License.
<dom-module id="gr-diff"> <dom-module id="gr-diff">
<template> <template>
<style include="shared-styles"> <style include="shared-styles">
:host(.no-left) .sideBySide ::content .left, :host(.no-left) .sideBySide .left,
:host(.no-left) .sideBySide ::content .left + td, :host(.no-left) .sideBySide .left + td,
:host(.no-left) .sideBySide ::content .right:not([data-value]), :host(.no-left) .sideBySide .right:not([data-value]),
:host(.no-left) .sideBySide ::content .right:not([data-value]) + td { :host(.no-left) .sideBySide .right:not([data-value]) + td {
display: none; display: none;
} }
::slotted(*) .thread-group { ::slotted(*) .thread-group {

2
polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard.html
View File

@@ -34,7 +34,7 @@ limitations under the License.
visibility: visible; visibility: visible;
opacity: 1; opacity: 1;
} }
:host ::content #hovercard { #hovercard {
background: var(--dialog-background-color); background: var(--dialog-background-color);
box-shadow: rgba(0, 0, 0, 0.3) 0 1px 3px; box-shadow: rgba(0, 0, 0, 0.3) 0 1px 3px;
padding: 1em; padding: 1em;

3
polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard_test.html
View File

@@ -41,7 +41,8 @@ limitations under the License.
suite('gr-hovercard tests', () => { suite('gr-hovercard tests', () => {
let element; let element;
let sandbox; let sandbox;
const TRANSITION_TIME = 200; // For css animations
const TRANSITION_TIME = 500;
setup(() => { setup(() => {
sandbox = sinon.sandbox.create(); sandbox = sinon.sandbox.create();

2
polygerrit-ui/app/test/index.html
View File

@@ -183,7 +183,7 @@ limitations under the License.
'shared/gr-editable-label/gr-editable-label_test.html', 'shared/gr-editable-label/gr-editable-label_test.html',
'shared/gr-formatted-text/gr-formatted-text_test.html', 'shared/gr-formatted-text/gr-formatted-text_test.html',
// TODO: uncomment file & fix tests. The file was missed in this list for a long time. // TODO: uncomment file & fix tests. The file was missed in this list for a long time.
// 'shared/gr-hovercard/gr-hovercard_test.html', 'shared/gr-hovercard/gr-hovercard_test.html',
'shared/gr-js-api-interface/gr-annotation-actions-context_test.html', 'shared/gr-js-api-interface/gr-annotation-actions-context_test.html',
'shared/gr-js-api-interface/gr-annotation-actions-js-api_test.html', 'shared/gr-js-api-interface/gr-annotation-actions-js-api_test.html',
'shared/gr-js-api-interface/gr-change-actions-js-api_test.html', 'shared/gr-js-api-interface/gr-change-actions-js-api_test.html',