opendev/gerrit
Code Issues Proposed changes

Bazel: Fix MisusedWeekYear error detected by ErrorProne

Browse Source 
Building Gerrit code with Bazel revealed MisusedWeekYear error detected
by ErrorProne: [1].

[1] http://errorprone.info/bugpattern/MisusedWeekYear
Change-Id: I95edf77a1922840e9e37a6125ba7d094be297516
This commit is contained in:
David Ostrovsky
2016-05-30 22:44:48 +02:00
parent 57d50755b7
commit 436ac12475
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gpg/src/test/java/com/google/gerrit/gpg/PublicKeyCheckerTest.java
View File

@@ -229,7 +229,7 @@ public class PublicKeyCheckerTest {
"Key is revoked (key material has been compromised): test6 compromised"; "Key is revoked (key material has been compromised): test6 compromised";
assertProblems(k, problem); assertProblems(k, problem);
SimpleDateFormat df = new SimpleDateFormat("YYYY-MM-dd HH:mm:ss"); SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
PublicKeyChecker checker = new PublicKeyChecker() PublicKeyChecker checker = new PublicKeyChecker()
.setStore(store) .setStore(store)
.setEffectiveTime(df.parse("2010-01-01 12:00:00")); .setEffectiveTime(df.parse("2010-01-01 12:00:00"));
@@ -392,7 +392,7 @@ public class PublicKeyCheckerTest {
} }
private static Date parseDate(String str) throws Exception { private static Date parseDate(String str) throws Exception {
return new SimpleDateFormat("YYYY-MM-dd HH:mm:ss Z").parse(str); return new SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z").parse(str);
} }
private static List<String> list(String first, String[] rest) { private static List<String> list(String first, String[] rest) {

2
gerrit-gpg/src/test/java/com/google/gerrit/gpg/PushCertificateCheckerTest.java
View File

@@ -139,7 +139,7 @@ public class PushCertificateCheckerTest {
@Test @Test
public void signatureByExpiredKeyBeforeExpiration() throws Exception { public void signatureByExpiredKeyBeforeExpiration() throws Exception {
TestKey key3 = expiredKey(); TestKey key3 = expiredKey();
Date now = new SimpleDateFormat("YYYY-MM-dd HH:mm:ss Z") Date now = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z")
.parse("2005-07-10 12:00:00 -0400"); .parse("2005-07-10 12:00:00 -0400");
PushCertificate cert = newSignedCert(validNonce(), key3, now); PushCertificate cert = newSignedCert(validNonce(), key3, now);
assertNoProblems(cert); assertNoProblems(cert);