opendev/gerrit
Code Issues Proposed changes

Merge "Fix JavaDoc of AccountControl#canSee"

Browse Source
This commit is contained in:
Edwin Kempin 2016-06-27 06:07:29 +00:00 committed by Gerrit Code Review
commit 43ed310f7e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/ReviewersUtil.java
View File

@ -231,7 +231,7 @@ public class ReviewersUtil {
if (!map.containsKey(account) if (!map.containsKey(account)
// Can the suggestion see the change? // Can the suggestion see the change?
&& visibilityControl.isVisibleTo(account) && visibilityControl.isVisibleTo(account)
// Can the account see the current user? // Can the current user see the account?
&& accountControl.canSee(account)) { && accountControl.canSee(account)) {
map.put(account, accountLoader.get(account)); map.put(account, accountLoader.get(account));
return true; return true;

4
gerrit-server/src/main/java/com/google/gerrit/server/account/AccountControl.java
View File

@ -79,7 +79,7 @@ public class AccountControl {
} }
/** /**
* Returns true if the otherUser is allowed to see the current user, based * Returns true if the current user is allowed to see the otherUser, based
* on the account visibility policy. Depending on the group membership * on the account visibility policy. Depending on the group membership
* realms supported, this may not be able to determine SAME_GROUP or * realms supported, this may not be able to determine SAME_GROUP or
* VISIBLE_GROUP correctly (defaulting to not being visible). This is because * VISIBLE_GROUP correctly (defaulting to not being visible). This is because
@ -91,7 +91,7 @@ public class AccountControl {
} }
/** /**
* Returns true if the otherUser is allowed to see the current user, based * Returns true if the current user is allowed to see the otherUser, based
* on the account visibility policy. Depending on the group membership * on the account visibility policy. Depending on the group membership
* realms supported, this may not be able to determine SAME_GROUP or * realms supported, this may not be able to determine SAME_GROUP or
* VISIBLE_GROUP correctly (defaulting to not being visible). This is because * VISIBLE_GROUP correctly (defaulting to not being visible). This is because