Rewrite our build as modular maven components
This refactoring splits the code up into different components, with their own per-component CLASSPATH. By moving all of our classes into isolated components we can better isolate the classpaths and try to avoid unexpected dependency problems. It also allows us to more clearly define which components are used by the GWT UI and thus must be compiled under GWT, and which components are run on the server and can therefore use more of the J2SE API. Change-Id: I833cc22bacc5655d1c9099ed7c2b0e0a5b08855a Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
		| @@ -0,0 +1,85 @@ | ||||
| // Copyright (C) 2008 The Android Open Source Project | ||||
| // | ||||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||||
| // you may not use this file except in compliance with the License. | ||||
| // You may obtain a copy of the License at | ||||
| // | ||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||
| // | ||||
| // Unless required by applicable law or agreed to in writing, software | ||||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||
| // See the License for the specific language governing permissions and | ||||
| // limitations under the License. | ||||
|  | ||||
| package com.google.gerrit.common.data; | ||||
|  | ||||
| import com.google.gerrit.reviewdb.Account; | ||||
| import com.google.gerrit.reviewdb.ApprovalCategory; | ||||
| import com.google.gerrit.reviewdb.PatchSetApproval; | ||||
|  | ||||
| import java.sql.Timestamp; | ||||
| import java.util.ArrayList; | ||||
| import java.util.Comparator; | ||||
| import java.util.HashMap; | ||||
| import java.util.List; | ||||
| import java.util.Map; | ||||
|  | ||||
| public class ApprovalDetail { | ||||
|   public static final Comparator<ApprovalDetail> SORT = | ||||
|       new Comparator<ApprovalDetail>() { | ||||
|         public int compare(final ApprovalDetail o1, final ApprovalDetail o2) { | ||||
|           int cmp; | ||||
|           cmp = o2.hasNonZero - o1.hasNonZero; | ||||
|           if (cmp != 0) return cmp; | ||||
|           return o1.sortOrder.compareTo(o2.sortOrder); | ||||
|         } | ||||
|       }; | ||||
|  | ||||
|   static final Timestamp EG_0 = new Timestamp(0); | ||||
|   static final Timestamp EG_D = new Timestamp(Long.MAX_VALUE); | ||||
|  | ||||
|   protected Account.Id account; | ||||
|   protected List<PatchSetApproval> approvals; | ||||
|  | ||||
|   private transient int hasNonZero; | ||||
|   private transient Timestamp sortOrder = EG_D; | ||||
|  | ||||
|   protected ApprovalDetail() { | ||||
|   } | ||||
|  | ||||
|   public ApprovalDetail(final Account.Id id) { | ||||
|     account = id; | ||||
|     approvals = new ArrayList<PatchSetApproval>(); | ||||
|   } | ||||
|  | ||||
|   public Account.Id getAccount() { | ||||
|     return account; | ||||
|   } | ||||
|  | ||||
|   public Map<ApprovalCategory.Id, PatchSetApproval> getApprovalMap() { | ||||
|     final HashMap<ApprovalCategory.Id, PatchSetApproval> r; | ||||
|     r = new HashMap<ApprovalCategory.Id, PatchSetApproval>(); | ||||
|     for (final PatchSetApproval ca : approvals) { | ||||
|       r.put(ca.getCategoryId(), ca); | ||||
|     } | ||||
|     return r; | ||||
|   } | ||||
|  | ||||
|   public void sortFirst() { | ||||
|     hasNonZero = 1; | ||||
|     sortOrder = ApprovalDetail.EG_0; | ||||
|   } | ||||
|  | ||||
|   public void add(final PatchSetApproval ca) { | ||||
|     approvals.add(ca); | ||||
|  | ||||
|     final Timestamp g = ca.getGranted(); | ||||
|     if (g != null && g.compareTo(sortOrder) < 0) { | ||||
|       sortOrder = g; | ||||
|     } | ||||
|     if (ca.getValue() != 0) { | ||||
|       hasNonZero = 1; | ||||
|     } | ||||
|   } | ||||
| } | ||||
		Reference in New Issue
	
	Block a user
	 Shawn O. Pearce
					Shawn O. Pearce