opendev/gerrit
Code Issues Proposed changes

Rewrite our build as modular maven components

Browse Source 
This refactoring splits the code up into different components, with
their own per-component CLASSPATH.  By moving all of our classes
into isolated components we can better isolate the classpaths and
try to avoid unexpected dependency problems.  It also allows us to
more clearly define which components are used by the GWT UI and
thus must be compiled under GWT, and which components are run on
the server and can therefore use more of the J2SE API.

Change-Id: I833cc22bacc5655d1c9099ed7c2b0e0a5b08855a
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-11-07 12:55:26 -08:00
parent 2464ac82b7
commit 44671f5c69
719 changed files with 9467 additions and 2417 deletions
Download Patch File Download Diff File Expand all files Collapse all files

170
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/CmdLineParser.java Normal file
View File

@@ -0,0 +1,170 @@
/*
* Copyright (C) 2008, Shawn O. Pearce <spearce@spearce.org>
*
* (Taken from JGit org.eclipse.jgit.pgm.opt.CmdLineParser.)
*
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* - Redistributions of source code must retain the above copyright notice, this
* list of conditions and the following disclaimer.
*
* - Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* - Neither the name of the Git Development Community nor the names of its
* contributors may be used to endorse or promote products derived from this
* software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*/
package com.google.gerrit.util.cli;
import com.google.inject.Inject;
import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.assistedinject.Assisted;
import org.kohsuke.args4j.Argument;
import org.kohsuke.args4j.CmdLineException;
import org.kohsuke.args4j.IllegalAnnotationError;
import org.kohsuke.args4j.Option;
import org.kohsuke.args4j.OptionDef;
import org.kohsuke.args4j.spi.OptionHandler;
import org.kohsuke.args4j.spi.Setter;
import java.io.Writer;
import java.util.ArrayList;
import java.util.ResourceBundle;
/**
* Extended command line parser which handles --foo=value arguments.
* <p>
* The args4j package does not natively handle --foo=value and instead prefers
* to see --foo value on the command line. Many users are used to the GNU style
* --foo=value long option, so we convert from the GNU style format to the
* args4j style format prior to invoking args4j for parsing.
*/
public class CmdLineParser {
public interface Factory {
CmdLineParser create(Object bean);
}
private final Injector injector;
private final MyParser parser;
/**
* Creates a new command line owner that parses arguments/options and set them
* into the given object.
*
* @param bean instance of a class annotated by
* {@link org.kohsuke.args4j.Option} and
* {@link org.kohsuke.args4j.Argument}. this object will receive
* values.
*
* @throws IllegalAnnotationError if the option bean class is using args4j
* annotations incorrectly.
*/
@Inject
public CmdLineParser(final Injector injector, @Assisted final Object bean)
throws IllegalAnnotationError {
this.injector = injector;
this.parser = new MyParser(bean);
}
public void addArgument(Setter<?> setter, Argument a) {
parser.addArgument(setter, a);
}
public void addOption(Setter<?> setter, Option o) {
parser.addOption(setter, o);
}
public void printSingleLineUsage(Writer w, ResourceBundle rb) {
parser.printSingleLineUsage(w, rb);
}
public void printUsage(Writer out, ResourceBundle rb) {
parser.printUsage(out, rb);
}
public void parseArgument(final String... args) throws CmdLineException {
final ArrayList<String> tmp = new ArrayList<String>(args.length);
for (int argi = 0; argi < args.length; argi++) {
final String str = args[argi];
if (str.equals("--")) {
while (argi < args.length)
tmp.add(args[argi++]);
break;
}
if (str.startsWith("--")) {
final int eq = str.indexOf('=');
if (eq > 0) {
tmp.add(str.substring(0, eq));
tmp.add(str.substring(eq + 1));
continue;
}
}
tmp.add(str);
}
parser.parseArgument(tmp.toArray(new String[tmp.size()]));
}
private class MyParser extends org.kohsuke.args4j.CmdLineParser {
MyParser(final Object bean) {
super(bean);
}
@SuppressWarnings("unchecked")
@Override
protected OptionHandler createOptionHandler(final OptionDef option,
final Setter setter) {
if (isHandlerSpecified(option) || isEnum(setter) || isPrimitive(setter)) {
return super.createOptionHandler(option, setter);
}
final Key<OptionHandlerFactory<?>> key =
OptionHandlerUtil.keyFor(setter.getType());
Injector i = injector;
while (i != null) {
if (i.getBindings().containsKey(key)) {
return i.getInstance(key).create(this, option, setter);
}
i = i.getParent();
}
return super.createOptionHandler(option, setter);
}
private boolean isHandlerSpecified(final OptionDef option) {
return option.handler() != OptionHandler.class;
}
@SuppressWarnings("unchecked")
private boolean isEnum(final Setter setter) {
return Enum.class.isAssignableFrom(setter.getType());
}
@SuppressWarnings("unchecked")
private boolean isPrimitive(final Setter setter) {
return setter.getType().isPrimitive();
}
}
}

26
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/OptionHandlerFactory.java Normal file
View File

@@ -0,0 +1,26 @@
// Copyright (C) 2009 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.util.cli;
import org.kohsuke.args4j.OptionDef;
import org.kohsuke.args4j.spi.OptionHandler;
import org.kohsuke.args4j.spi.Setter;
/** Creates an args4j OptionHandler through a Guice Injector. */
public interface OptionHandlerFactory<T> {
@SuppressWarnings("unchecked")
OptionHandler create(org.kohsuke.args4j.CmdLineParser cmdLineParser,
OptionDef optionDef, Setter setter);
}

36
gerrit-util-cli/src/main/java/com/google/gerrit/util/cli/OptionHandlerUtil.java Normal file
View File

@@ -0,0 +1,36 @@
// Copyright (C) 2009 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.util.cli;
import com.google.inject.Key;
import com.google.inject.TypeLiteral;
import com.google.inject.internal.MoreTypes.ParameterizedTypeImpl;
import java.lang.reflect.Type;
/** Utilities to support creating OptionHandler instances. */
public class OptionHandlerUtil {
/** Generate a key for an {@link OptionHandlerFactory} in Guice. */
@SuppressWarnings("unchecked")
public static <T> Key<OptionHandlerFactory<T>> keyFor(final Class<T> valueType) {
final Type factoryType =
new ParameterizedTypeImpl(null, OptionHandlerFactory.class, valueType);
return (Key<OptionHandlerFactory<T>>) Key.get(TypeLiteral.get(factoryType));
}
private OptionHandlerUtil() {
}
}