From 44b3a7c43304deab225a694982e6a4b0f5c966b6 Mon Sep 17 00:00:00 2001 From: Paladox none Date: Tue, 6 Aug 2019 14:36:29 +0000 Subject: [PATCH] Migrate from Polymer fire to Gerrit.FireBehavior Polymer 2 deprecates the 'fire' method for legacy elements. So let's use gerrit's core fire method which is almost exactly the same. Change-Id: I59aebd29a89d26d9cb39e63e9a41afa9756b942f --- .../elements/admin/gr-access-section/gr-access-section.html | 1 + .../elements/admin/gr-access-section/gr-access-section.js | 5 +++++ .../admin/gr-admin-group-list/gr-admin-group-list.html | 1 + .../admin/gr-admin-group-list/gr-admin-group-list.js | 1 + .../gr-confirm-delete-item-dialog.html | 1 + .../gr-confirm-delete-item-dialog.js | 4 ++++ .../gr-create-change-dialog/gr-create-change-dialog.html | 1 + .../admin/gr-create-change-dialog/gr-create-change-dialog.js | 5 +++++ .../admin/gr-group-audit-log/gr-group-audit-log.html | 1 + .../elements/admin/gr-group-audit-log/gr-group-audit-log.js | 1 + .../elements/admin/gr-group-members/gr-group-members.html | 1 + .../app/elements/admin/gr-group-members/gr-group-members.js | 1 + polygerrit-ui/app/elements/admin/gr-group/gr-group.html | 1 + polygerrit-ui/app/elements/admin/gr-group/gr-group.js | 4 ++++ .../app/elements/admin/gr-permission/gr-permission.html | 1 + .../app/elements/admin/gr-permission/gr-permission.js | 5 +++++ .../app/elements/admin/gr-plugin-list/gr-plugin-list.html | 1 + .../app/elements/admin/gr-plugin-list/gr-plugin-list.js | 1 + .../app/elements/admin/gr-repo-access/gr-repo-access.html | 3 ++- .../app/elements/admin/gr-repo-access/gr-repo-access.js | 1 + .../elements/admin/gr-repo-commands/gr-repo-commands.html | 1 + .../app/elements/admin/gr-repo-commands/gr-repo-commands.js | 4 ++++ .../admin/gr-repo-dashboards/gr-repo-dashboards.html | 1 + .../elements/admin/gr-repo-dashboards/gr-repo-dashboards.js | 4 ++++ .../admin/gr-repo-detail-list/gr-repo-detail-list.html | 1 + .../admin/gr-repo-detail-list/gr-repo-detail-list.js | 1 + polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html | 1 + polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js | 4 ++++ .../app/elements/admin/gr-rule-editor/gr-rule-editor.html | 1 + .../app/elements/admin/gr-rule-editor/gr-rule-editor.js | 5 +++++ .../change-list/gr-change-list-view/gr-change-list-view.html | 1 + .../change-list/gr-change-list-view/gr-change-list-view.js | 1 + .../elements/change-list/gr-change-list/gr-change-list.html | 1 + .../elements/change-list/gr-change-list/gr-change-list.js | 1 + .../change-list/gr-dashboard-view/gr-dashboard-view.html | 1 + .../change-list/gr-dashboard-view/gr-dashboard-view.js | 1 + .../elements/change/gr-account-entry/gr-account-entry.html | 1 + .../app/elements/change/gr-account-entry/gr-account-entry.js | 1 + .../app/elements/change/gr-account-list/gr-account-list.html | 1 + .../app/elements/change/gr-account-list/gr-account-list.js | 5 +++++ .../elements/change/gr-change-actions/gr-change-actions.html | 1 + .../elements/change/gr-change-actions/gr-change-actions.js | 1 + .../app/elements/change/gr-change-view/gr-change-view.html | 1 + .../app/elements/change/gr-change-view/gr-change-view.js | 1 + .../gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html | 1 + .../gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js | 1 + .../gr-confirm-cherrypick-conflict-dialog.html | 1 + .../gr-confirm-cherrypick-conflict-dialog.js | 4 ++++ .../gr-confirm-cherrypick-dialog.html | 1 + .../gr-confirm-cherrypick-dialog.js | 4 ++++ .../gr-confirm-move-dialog/gr-confirm-move-dialog.html | 1 + .../change/gr-confirm-move-dialog/gr-confirm-move-dialog.js | 4 ++++ .../gr-confirm-revert-dialog/gr-confirm-revert-dialog.html | 1 + .../gr-confirm-revert-dialog/gr-confirm-revert-dialog.js | 4 ++++ .../change/gr-download-dialog/gr-download-dialog.html | 1 + .../elements/change/gr-download-dialog/gr-download-dialog.js | 1 + .../change/gr-file-list-header/gr-file-list-header.html | 1 + .../change/gr-file-list-header/gr-file-list-header.js | 1 + .../app/elements/change/gr-file-list/gr-file-list.html | 1 + .../app/elements/change/gr-file-list/gr-file-list.js | 1 + .../change/gr-included-in-dialog/gr-included-in-dialog.html | 1 + .../change/gr-included-in-dialog/gr-included-in-dialog.js | 4 ++++ polygerrit-ui/app/elements/change/gr-message/gr-message.html | 1 + polygerrit-ui/app/elements/change/gr-message/gr-message.js | 4 ++++ .../gr-related-changes-list/gr-related-changes-list.html | 1 + .../gr-related-changes-list/gr-related-changes-list.js | 1 + .../app/elements/change/gr-reply-dialog/gr-reply-dialog.html | 1 + .../app/elements/change/gr-reply-dialog/gr-reply-dialog.js | 1 + .../elements/change/gr-reviewer-list/gr-reviewer-list.html | 1 + .../app/elements/change/gr-reviewer-list/gr-reviewer-list.js | 4 ++++ .../change/gr-upload-help-dialog/gr-upload-help-dialog.html | 1 + .../change/gr-upload-help-dialog/gr-upload-help-dialog.js | 4 ++++ .../app/elements/core/gr-error-manager/gr-error-manager.html | 1 + .../app/elements/core/gr-error-manager/gr-error-manager.js | 1 + .../gr-keyboard-shortcuts-dialog.html | 1 + .../gr-keyboard-shortcuts-dialog.js | 1 + .../app/elements/core/gr-main-header/gr-main-header.html | 1 + .../app/elements/core/gr-main-header/gr-main-header.js | 1 + polygerrit-ui/app/elements/core/gr-router/gr-router.html | 1 + polygerrit-ui/app/elements/core/gr-router/gr-router.js | 1 + .../app/elements/diff/gr-diff-builder/gr-diff-builder.html | 5 +++++ .../elements/diff/gr-diff-highlight/gr-diff-highlight.html | 3 ++- .../app/elements/diff/gr-diff-highlight/gr-diff-highlight.js | 4 ++++ .../app/elements/diff/gr-diff-host/gr-diff-host.html | 1 + polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js | 1 + .../gr-diff-preferences-dialog.html | 1 + .../gr-diff-preferences-dialog/gr-diff-preferences-dialog.js | 4 ++++ .../app/elements/diff/gr-diff-view/gr-diff-view.html | 1 + polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js | 1 + polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html | 1 + polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js | 1 + .../gr-selection-action-box/gr-selection-action-box.html | 1 + .../diff/gr-selection-action-box/gr-selection-action-box.js | 1 + .../app/elements/edit/gr-editor-view/gr-editor-view.html | 1 + .../app/elements/edit/gr-editor-view/gr-editor-view.js | 1 + .../elements/plugins/gr-event-helper/gr-event-helper.html | 1 + .../plugins/gr-event-helper/gr-event-helper_test.html | 5 +++++ .../elements/settings/gr-account-info/gr-account-info.html | 1 + .../app/elements/settings/gr-account-info/gr-account-info.js | 4 ++++ .../app/elements/settings/gr-cla-view/gr-cla-view.html | 1 + .../app/elements/settings/gr-cla-view/gr-cla-view.js | 1 + .../gr-registration-dialog/gr-registration-dialog.html | 1 + .../gr-registration-dialog/gr-registration-dialog.js | 4 ++++ .../elements/settings/gr-settings-view/gr-settings-view.html | 1 + .../elements/settings/gr-settings-view/gr-settings-view.js | 1 + .../app/elements/shared/gr-account-chip/gr-account-chip.html | 1 + .../app/elements/shared/gr-account-chip/gr-account-chip.js | 4 ++++ .../gr-autocomplete-dropdown/gr-autocomplete-dropdown.html | 1 + .../gr-autocomplete-dropdown/gr-autocomplete-dropdown.js | 1 + .../app/elements/shared/gr-autocomplete/gr-autocomplete.html | 1 + .../app/elements/shared/gr-autocomplete/gr-autocomplete.js | 1 + .../elements/shared/gr-comment-thread/gr-comment-thread.html | 1 + .../elements/shared/gr-comment-thread/gr-comment-thread.js | 4 ++++ polygerrit-ui/app/elements/shared/gr-comment/gr-comment.html | 1 + polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js | 1 + .../gr-confirm-delete-comment-dialog.html | 1 + .../gr-confirm-delete-comment-dialog.js | 4 ++++ polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.html | 1 + polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js | 4 ++++ .../shared/gr-editable-content/gr-editable-content.html | 1 + .../shared/gr-editable-content/gr-editable-content.js | 4 ++++ .../elements/shared/gr-editable-label/gr-editable-label.html | 1 + .../elements/shared/gr-editable-label/gr-editable-label.js | 1 + .../app/elements/shared/gr-linked-chip/gr-linked-chip.html | 1 + .../app/elements/shared/gr-linked-chip/gr-linked-chip.js | 4 ++++ .../app/elements/shared/gr-list-view/gr-list-view.html | 1 + .../app/elements/shared/gr-list-view/gr-list-view.js | 1 + polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.html | 1 + polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js | 1 + .../shared/gr-rest-api-interface/gr-rest-api-interface.html | 1 + .../shared/gr-rest-api-interface/gr-rest-api-interface.js | 1 + polygerrit-ui/app/elements/shared/gr-select/gr-select.html | 2 ++ polygerrit-ui/app/elements/shared/gr-select/gr-select.js | 5 +++++ .../app/elements/shared/gr-textarea/gr-textarea.html | 1 + polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js | 1 + 135 files changed, 239 insertions(+), 2 deletions(-) diff --git a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html index cddbbf3543..6eceb25904 100644 --- a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html +++ b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js index 9841e67fde..fbde87bce0 100644 --- a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js +++ b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js @@ -71,6 +71,11 @@ behaviors: [ Gerrit.AccessBehavior, + /** + * Unused in this element, but called by other elements in tests + * e.g gr-repo-access_test. + */ + Gerrit.FireBehavior, ], listeners: { diff --git a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.html b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.html index b2a3105180..bf1086c5c7 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.html +++ b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js index aca691ae60..edf584578b 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js +++ b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js @@ -68,6 +68,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.ListViewBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.html b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.html index b7932dd8b9..9d8ee18d8d 100644 --- a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.html +++ b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js index 9c0e405292..a99c9b1fdc 100644 --- a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js +++ b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js @@ -44,6 +44,10 @@ itemType: String, }, + behaviors: [ + Gerrit.FireBehavior, + ], + _handleConfirmTap(e) { e.preventDefault(); e.stopPropagation(); diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html index 518905c172..7b88f9e423 100644 --- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html +++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html @@ -19,6 +19,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js index 7eec959dc2..128eb85f68 100644 --- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js +++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js @@ -50,6 +50,11 @@ behaviors: [ Gerrit.BaseUrlBehavior, + /** + * Unused in this element, but called by other elements in tests + * e.g gr-repo-commands_test. + */ + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.html b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.html index 08131abadc..b2e8045428 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.html +++ b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js index 966f3c9eca..3b418117ca 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js +++ b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js @@ -33,6 +33,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.ListViewBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.html b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.html index 52cbfb31cd..d37b49f2c4 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.html +++ b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js index 8a262b8f3e..915f748c46 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js +++ b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js @@ -66,6 +66,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-group/gr-group.html b/polygerrit-ui/app/elements/admin/gr-group/gr-group.html index a3bbddc922..b7654c8e0f 100644 --- a/polygerrit-ui/app/elements/admin/gr-group/gr-group.html +++ b/polygerrit-ui/app/elements/admin/gr-group/gr-group.html @@ -15,6 +15,7 @@ See the License for the specific language governing permissions and limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-group/gr-group.js b/polygerrit-ui/app/elements/admin/gr-group/gr-group.js index 095a0f9a48..deccab6904 100644 --- a/polygerrit-ui/app/elements/admin/gr-group/gr-group.js +++ b/polygerrit-ui/app/elements/admin/gr-group/gr-group.js @@ -89,6 +89,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + observers: [ '_handleConfigName(_groupConfig.name)', '_handleConfigOwner(_groupConfig.owner, _groupConfigOwner)', diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html index 78c30ff8f6..bf11f371a7 100644 --- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html +++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js index 64e156ba44..02914e5781 100644 --- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js +++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js @@ -76,6 +76,11 @@ behaviors: [ Gerrit.AccessBehavior, + /** + * Unused in this element, but called by other elements in tests + * e.g gr-access-section_test. + */ + Gerrit.FireBehavior, ], observers: [ diff --git a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.html b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.html index 26f37e1165..6ef84bfaaa 100644 --- a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.html +++ b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js index d533f986ed..9656eeeb1d 100644 --- a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js +++ b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js @@ -65,6 +65,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.ListViewBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.html b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.html index 40d32d4898..408a4d1440 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.html @@ -17,8 +17,9 @@ limitations under the License. - + + diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js index 7d47d08833..61362a809d 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js @@ -118,6 +118,7 @@ behaviors: [ Gerrit.AccessBehavior, Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.html b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.html index 63c2a97a60..5089f346b3 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js index 169672aa0a..b6f7039115 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js @@ -42,6 +42,10 @@ _canCreate: Boolean, }, + behaviors: [ + Gerrit.FireBehavior, + ], + attached() { this._loadRepo(); diff --git a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.html b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.html index 6cc0958f98..29f70dc298 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.html @@ -15,6 +15,7 @@ See the License for the specific language governing permissions and limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js index 72ee83da13..6b20289c78 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js @@ -33,6 +33,10 @@ _dashboards: Array, }, + behaviors: [ + Gerrit.FireBehavior, + ], + _repoChanged(repo) { this._loading = true; if (!repo) { return Promise.resolve(); } diff --git a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html index e284201e77..964ee116ae 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html +++ b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html @@ -19,6 +19,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js index 8b919775f5..e50c498a82 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js @@ -85,6 +85,7 @@ behaviors: [ Gerrit.ListViewBehavior, + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html index 52f143cc60..7eb1033741 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html +++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js index fded936fb0..37eff2c765 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js +++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js @@ -109,6 +109,10 @@ _schemesObj: Object, }, + behaviors: [ + Gerrit.FireBehavior, + ], + observers: [ '_handleConfigChanged(_repoConfig.*)', ], diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html index 7ba541f7b0..5a908781a3 100644 --- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html +++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js index 4b01b18f5c..f206514e15 100644 --- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js +++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js @@ -95,6 +95,11 @@ behaviors: [ Gerrit.AccessBehavior, Gerrit.BaseUrlBehavior, + /** + * Unused in this element, but called by other elements in tests + * e.g gr-permission_test. + */ + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.html b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.html index 1ca5668aba..8a16c47d26 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js index d546fe3481..e72b788fed 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js @@ -41,6 +41,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.html b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.html index 616763056a..71ef6e43fb 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.html @@ -21,6 +21,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js index 57d6f8af63..077af1f54f 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js @@ -105,6 +105,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, Gerrit.ChangeTableBehavior, + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, Gerrit.RESTClientBehavior, Gerrit.URLEncodingBehavior, diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html index 4360d5d637..6e58166c63 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js index 608aaf759e..2b3c5c89d7 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js @@ -76,6 +76,7 @@ ], behaviors: [ + Gerrit.FireBehavior, Gerrit.RESTClientBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html index 95ef881141..03fc6062cf 100644 --- a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html +++ b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.js b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.js index 147d1f2d07..1cb1ca58fc 100644 --- a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.js +++ b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.js @@ -76,6 +76,7 @@ behaviors: [ Gerrit.AnonymousNameBehavior, + Gerrit.FireBehavior, ], attached() { diff --git a/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.html b/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.html index 9cb936ae69..31c1be531c 100644 --- a/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.html +++ b/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.js b/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.js index c10f3d5ad7..479fee281d 100644 --- a/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.js +++ b/polygerrit-ui/app/elements/change/gr-account-list/gr-account-list.js @@ -84,6 +84,11 @@ }, }, + behaviors: [ + // Used in the tests for gr-account-list and other elements tests. + Gerrit.FireBehavior, + ], + listeners: { remove: '_handleRemove', }, diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html index 1e50e4bfba..8de59f458d 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js index 881e7f40ad..90641dfd9f 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js @@ -408,6 +408,7 @@ RevisionActions, behaviors: [ + Gerrit.FireBehavior, Gerrit.PatchSetBehavior, Gerrit.RESTClientBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html index 4860490af3..ec79438d1f 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js index ae361d7196..3a5f32669c 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js @@ -281,6 +281,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, Gerrit.PatchSetBehavior, Gerrit.RESTClientBehavior, diff --git a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html index 145d12697c..3a27c01e04 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js index a371e13eb9..6b7163a743 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js @@ -38,6 +38,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.html index 55b14b15c5..b9e91559a6 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js index 2e8af0e140..b26842ac72 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js @@ -21,6 +21,10 @@ is: 'gr-confirm-cherrypick-conflict-dialog', _legacyUndefinedCheck: true, + behaviors: [ + Gerrit.FireBehavior, + ], + /** * Fired when the confirm button is pressed. * diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html index 767b62da52..303a55cfa6 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js index fa281ecc09..f4523cff75 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js @@ -51,6 +51,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + observers: [ '_computeMessage(changeStatus, commitNum, commitMessage)', ], diff --git a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html index c07bb378b2..1db5b52909 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js index 093dca66bb..2d3c0e3a81 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js @@ -47,6 +47,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + _handleConfirmTap(e) { e.preventDefault(); this.fire('confirm', null, {bubbles: false}); diff --git a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html index c68912c034..e7dd6ac2bf 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js index 93e21c77c8..f4ad002b24 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js @@ -40,6 +40,10 @@ message: String, }, + behaviors: [ + Gerrit.FireBehavior, + ], + populateRevertMessage(message, commitHash) { // Figure out what the revert title should be. const originalTitle = message.split('\n')[0]; diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html index ab7525f08a..95f63ee8ff 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js index 9bfe3a97b0..65dbeee806 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js @@ -48,6 +48,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.PatchSetBehavior, Gerrit.RESTClientBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html index bdb4295f1c..224e944346 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html +++ b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js index 250900acd8..a802fb99b3 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js +++ b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js @@ -94,6 +94,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.PatchSetBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html index f087b2107a..61fdac2a2f 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js index db41da04ca..4f160e4f21 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js @@ -185,6 +185,7 @@ behaviors: [ Gerrit.AsyncForeachBehavior, Gerrit.DomUtilBehavior, + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, Gerrit.PatchSetBehavior, Gerrit.PathListBehavior, diff --git a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html index d5d8128d51..8fa6b08ae2 100644 --- a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js index 7755a60099..4f63626ab5 100644 --- a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js @@ -45,6 +45,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + loadData() { if (!this.changeNum) { return; } this._filterText = ''; diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message.html b/polygerrit-ui/app/elements/change/gr-message/gr-message.html index df3cc371ce..b828327243 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message.html +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message.js b/polygerrit-ui/app/elements/change/gr-message/gr-message.js index a2ec28c8b2..e0e37259cf 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message.js +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message.js @@ -104,6 +104,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + observers: [ '_updateExpandedClass(message.expanded)', ], diff --git a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.html b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.html index 4a70506b2f..5d3291d391 100644 --- a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.html +++ b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js index 07bf139cde..eeec437839 100644 --- a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js +++ b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js @@ -78,6 +78,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.PatchSetBehavior, Gerrit.RESTClientBehavior, ], diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html index 6612180be3..08a3ec3cbf 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js index cd93a2c5c7..cd42606b29 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js @@ -226,6 +226,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, Gerrit.PatchSetBehavior, Gerrit.RESTClientBehavior, diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.html b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.html index 46f973eae0..6e2686ef5a 100644 --- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.html +++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js index 1cae50a66b..43ea7f0972 100644 --- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js +++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js @@ -75,6 +75,10 @@ _xhrPromise: Object, }, + behaviors: [ + Gerrit.FireBehavior, + ], + observers: [ '_reviewersChanged(change.reviewers.*, change.owner)', ], diff --git a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.html b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.html index ff4ab399f1..72b93bed8c 100644 --- a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.html +++ b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js index df96be2d8f..c652658027 100644 --- a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js @@ -58,6 +58,10 @@ }, }, + behaviors: [ + Gerrit.FireBehavior, + ], + attached() { this.$.restAPI.getLoggedIn().then(loggedIn => { if (loggedIn) { diff --git a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.html b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.html index db40496b27..048d39227e 100644 --- a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.html +++ b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js index 38dfecb5a3..54cfe190f3 100644 --- a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js +++ b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js @@ -31,6 +31,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, ], properties: { diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.html b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.html index e153074c8e..8b2751c440 100644 --- a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.html +++ b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.html @@ -16,6 +16,7 @@ limitations under the License. --> + diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js index f206db1496..4ecbfb36b6 100644 --- a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js +++ b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js @@ -51,6 +51,7 @@ }, behaviors: [ + Gerrit.FireBehavior, Gerrit.KeyboardShortcutBehavior, ], diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.html b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.html index 37cb3173cc..60ccac10f1 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.html +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.html @@ -18,6 +18,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js index 496f8d31f2..77f9cd77c1 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js @@ -138,6 +138,7 @@ Gerrit.AdminNavBehavior, Gerrit.BaseUrlBehavior, Gerrit.DocsUrlBehavior, + Gerrit.FireBehavior, ], observers: [ diff --git a/polygerrit-ui/app/elements/core/gr-router/gr-router.html b/polygerrit-ui/app/elements/core/gr-router/gr-router.html index 6035069f61..71a58321a7 100644 --- a/polygerrit-ui/app/elements/core/gr-router/gr-router.html +++ b/polygerrit-ui/app/elements/core/gr-router/gr-router.html @@ -17,6 +17,7 @@ limitations under the License. + diff --git a/polygerrit-ui/app/elements/core/gr-router/gr-router.js b/polygerrit-ui/app/elements/core/gr-router/gr-router.js index 4d70bdc778..f19052c7e0 100644 --- a/polygerrit-ui/app/elements/core/gr-router/gr-router.js +++ b/polygerrit-ui/app/elements/core/gr-router/gr-router.js @@ -227,6 +227,7 @@ behaviors: [ Gerrit.BaseUrlBehavior, + Gerrit.FireBehavior, Gerrit.PatchSetBehavior, Gerrit.URLEncodingBehavior, ], diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.html b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.html index ddbb1df5b5..ca2c928bd3 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.html +++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.html @@ -15,6 +15,7 @@ See the License for the specific language governing permissions and limitations under the License. --> + @@ -139,6 +140,10 @@ limitations under the License. _cancelableRenderPromise: Object, }, + behaviors: [ + Gerrit.FireBehavior, + ], + get diffElement() { return this.queryEffectiveChildren('#diffTable'); }, diff --git a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.html b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.html index 612aab64e5..0364ceb1af 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.html +++ b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.html @@ -16,8 +16,9 @@ limitations under the License. --> - + +