opendev/gerrit
Code Issues Proposed changes

EditPreferencesBox: Simplify initKeyMapType()

Browse Source 
Loop over KeyMapType.values() instead of explicitly listing them.

Change-Id: I53dd3372c2860bf2a565485fa8f27438361af1bc
This commit is contained in:
Michael Zhou
2016-04-22 03:58:11 -04:00
parent 387e3a4257
commit 4534467668
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditPreferencesBox.java
View File

@@ -315,17 +315,8 @@ public class EditPreferencesBox extends Composite {
}
private void initKeyMapType() {
keyMap.addItem(
KeyMapType.DEFAULT.name().toLowerCase(),
KeyMapType.DEFAULT.name());
keyMap.addItem(
KeyMapType.EMACS.name().toLowerCase(),
KeyMapType.EMACS.name());
keyMap.addItem(
KeyMapType.SUBLIME.name().toLowerCase(),
KeyMapType.SUBLIME.name());
keyMap.addItem(
KeyMapType.VIM.name().toLowerCase(),
KeyMapType.VIM.name());
for (KeyMapType t : KeyMapType.values()) {
keyMap.addItem(t.name().toLowerCase(), t.name());
}
}
}