opendev/gerrit
Code Issues Proposed changes

Unify SideBySide2 header widgets

Browse Source 
Combine the two header widgets into a single panel and compact
the entire display to take up less overall screen space. The
header is now only a single line of text.

The format looks like:

  [x] path/of/FILE                                   < ^ >

The reviewed checkbox is on the left next to the file name.

The path uses plain text for the directory part and BOLD for the
file name itself. This makes it easier to spot the specific file
name being reviewed.

The navigation arrows are now clustered on the right using a
small icon for each. This saves a lot of screen space.

Change-Id: Ibd6b7e1022bfe3d6e97638df1fc94f492dae9af1
This commit is contained in:
Shawn Pearce
2013-08-09 15:39:36 -07:00
parent 7fd72a6b4c
commit 45b5ddeae8
10 changed files with 140 additions and 231 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.ui.xml
View File

@@ -17,9 +17,8 @@ limitations under the License.
<ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'
xmlns:g='urn:import:com.google.gwt.user.client.ui'
xmlns:d='urn:import:com.google.gerrit.client.diff'>
<g:HTMLPanel>
<d:ReviewedPanel ui:field='reviewed'/>
<d:NavLinks2 ui:field='navLinks'/>
<g:FlowPanel>
<d:Header ui:field='header'/>
<d:DiffTable ui:field='diffTable'/>
</g:HTMLPanel>
</g:FlowPanel>
</ui:UiBinder>