opendev/gerrit
Code Issues Proposed changes

Replace color: black with variable

Browse Source 
This change also applies this variable in a few places -- due to shady
DOM style scoping, the value being applied to the body tag is not
enough to completely style the content.

Change-Id: Iebeb1833da399d3257be6dc38767280c2e38e209
This commit is contained in:
Kasper Nilsson
2018-04-16 11:34:59 +02:00
parent c5ebc32ee9
commit 45e9c0d812
5 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html
View File

@@ -105,7 +105,7 @@ limitations under the License.
display: none; display: none;
} }
gr-linked-chip { gr-linked-chip {
--linked-chip-text-color: black; --linked-chip-text-color: var(--primary-text-color);
} }
.expanded #collapseBtn, .expanded #collapseBtn,
.openFile .fileViewActions { .openFile .fileViewActions {

2
polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.html
View File

@@ -62,7 +62,7 @@ limitations under the License.
@apply(--vote-chip-styles); @apply(--vote-chip-styles);
} }
--gr-button-background: var(--button-background-color, #f5f5f5); --gr-button-background: var(--button-background-color, #f5f5f5);
--gr-button-color: black; --gr-button-color: var(--primary-text-color);
} }
iron-selector > gr-button.iron-selected.max { iron-selector > gr-button.iron-selected.max {
--button-background-color: var(--vote-color-max); --button-background-color: var(--vote-color-max);

3
polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.html
View File

@@ -43,6 +43,9 @@ limitations under the License.
<dom-module id="gr-settings-view"> <dom-module id="gr-settings-view">
<template> <template>
<style include="shared-styles"> <style include="shared-styles">
:host {
color: var(--primary-text-color);
}
#newEmailInput { #newEmailInput {
width: 20em; width: 20em;
} }

2
polygerrit-ui/app/styles/gr-page-nav-styles.html
View File

@@ -55,7 +55,7 @@ limitations under the License.
font-family: var(--font-family-bold); font-family: var(--font-family-bold);
} }
.navStyles a { .navStyles a {
color: black; color: var(--primary-text-color);
display: inline-block; display: inline-block;
margin: .4em 0; margin: .4em 0;
} }

4
polygerrit-ui/app/styles/shared-styles.html
View File

@@ -92,7 +92,6 @@ limitations under the License.
border-left: 1px solid rgba(0, 0, 0, .3); border-left: 1px solid rgba(0, 0, 0, .3);
height: 20px; height: 20px;
margin: 0 8px; margin: 0 8px;
} }
.separator.transparent { .separator.transparent {
border-color: transparent; border-color: transparent;
@@ -104,6 +103,9 @@ limitations under the License.
strong { strong {
font-family: var(--font-family-bold); font-family: var(--font-family-bold);
} }
:host {
color: var(--primary-text-color);
}
</style> </style>
</template> </template>
</dom-module> </dom-module>