From 45f1486f36831ed33700459b0493af33150f57cf Mon Sep 17 00:00:00 2001 From: Christian Aistleitner Date: Sun, 5 May 2013 15:05:01 +0200 Subject: [PATCH] Re-add comment why connection pooling is turned off for MySQL The added comment was added in fb5548efcb05473eb5788d786e08fb25c21f8aa2 but got lost during a refactoring. Change-Id: Iaaad17f7b9ff76555e7a2b5d4c02134d12a32013 --- .../src/main/java/com/google/gerrit/server/schema/MySql.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java index 8c46732ef8..308cec8ec6 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java @@ -47,6 +47,10 @@ class MySql extends BaseDataSourceType { @Override public boolean usePool() { + // MySQL has given us trouble with the connection pool, + // sometimes the backend disconnects and the pool winds + // up with a stale connection. Fortunately opening up + // a new MySQL connection is usually very fast. return false; } } \ No newline at end of file