opendev/gerrit
Code Issues Proposed changes

SideBySide2: Fix toggling of reviewed box

Browse Source 
The flag should be unset if its already set.  This is handled in the
caller by saying !isReviewed() but the argument was ignored.  Use the
argument the caller supplied to ensure the correct state is used.

Change-Id: I157090336065d7c3f8409d395c5ca53c03f940d5
This commit is contained in:
Shawn Pearce
2013-07-19 16:55:51 -07:00
parent 8972811c6a
commit 45fc8fc5d2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/ReviewedPanel.java
View File

@@ -59,7 +59,7 @@ class ReviewedPanel extends Composite {
}
void setReviewed(boolean reviewed) {
checkBox.setValue(true, true);
checkBox.setValue(reviewed, true);
}
boolean isReviewed() {