From 463eb89a91ee6988f2a57ba05041f88edab33043 Mon Sep 17 00:00:00 2001 From: Luca Milanesio Date: Fri, 15 Jan 2021 23:13:24 +0000 Subject: [PATCH] Avoid magic values in RevisionDiffIT The updated commit message literal is used as magic value in multiple tests of RevisionDiffIT. Introduce a common constant that represents what the test value means, so that tests become more readable. Change-Id: I8d9f00e343169b135550b83d47974f7a2e4d4cd3 --- .../gerrit/acceptance/api/revision/RevisionDiffIT.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java b/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java index 057f837188..4c5b088deb 100644 --- a/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java +++ b/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java @@ -72,6 +72,7 @@ public class RevisionDiffIT extends AbstractDaemonTest { .mapToObj(number -> String.format("Line %d\n", number)) .collect(joining()); private static final String FILE_CONTENT2 = "1st line\n2nd line\n3rd line\n"; + private static final String UPDATED_COMMIT_MESSAGE = "An unchanged patchset"; private boolean intraline; private ObjectId commit1; @@ -406,7 +407,7 @@ public class RevisionDiffIT extends AbstractDaemonTest { gApi.changes().id(changeId).edit().modifyFile(filePath, RawInputUtil.create(fileContent)); gApi.changes().id(changeId).edit().publish(); String previousPatchSetId = gApi.changes().id(changeId).get().currentRevision; - gApi.changes().id(changeId).edit().modifyCommitMessage("An unchanged patchset"); + gApi.changes().id(changeId).edit().modifyCommitMessage(UPDATED_COMMIT_MESSAGE); gApi.changes().id(changeId).edit().publish(); DiffInfo diffInfo = @@ -428,7 +429,7 @@ public class RevisionDiffIT extends AbstractDaemonTest { gApi.changes().id(changeId).edit().modifyFile(filePath, RawInputUtil.create(fileContent)); gApi.changes().id(changeId).edit().publish(); String previousPatchSetId = gApi.changes().id(changeId).get().currentRevision; - gApi.changes().id(changeId).edit().modifyCommitMessage("An unchanged patchset"); + gApi.changes().id(changeId).edit().modifyCommitMessage(UPDATED_COMMIT_MESSAGE); gApi.changes().id(changeId).edit().publish(); DiffInfo diffInfo = @@ -446,7 +447,7 @@ public class RevisionDiffIT extends AbstractDaemonTest { gApi.changes().id(changeId).edit().modifyFile(filePath, RawInputUtil.create(fileContent)); gApi.changes().id(changeId).edit().publish(); String previousPatchSetId = gApi.changes().id(changeId).get().currentRevision; - gApi.changes().id(changeId).edit().modifyCommitMessage("An unchanged patchset"); + gApi.changes().id(changeId).edit().modifyCommitMessage(UPDATED_COMMIT_MESSAGE); gApi.changes().id(changeId).edit().publish(); DiffInfo diffInfo =