InlineEdit: Add POST /changes/<id>/rebase_edit REST endpoint

Add REST endpoint to rebase change edit on latest patch set.

Change-Id: If99d3a61375b90577b5cff0e09ff4cc24412cafd
This commit is contained in:
David Ostrovsky
2014-08-16 02:19:13 +02:00
parent e9988f9d00
commit 46999d2aa1
4 changed files with 178 additions and 0 deletions

View File

@@ -1315,6 +1315,29 @@ As response "`204 No Content`" is returned.
HTTP/1.1 204 No Content HTTP/1.1 204 No Content
---- ----
[[rebase-edit]]
=== Rebase Change Edit
--
'POST /changes/link:#change-id[\{change-id\}]/rebase_edit
--
Rebases change edit on top of latest patch set.
.Request
----
POST /changes/myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940/rebase_edit HTTP/1.0
----
When change was rebased on top of latest patch set, response
"`204 No Content`" is returned. When change edit is aready
based on top of the latest patch set, the response
"`409 Conflict`" is returned.
.Response
----
HTTP/1.1 204 No Content
----
[[reviewer-endpoints]] [[reviewer-endpoints]]
== Reviewer Endpoints == Reviewer Endpoints

View File

@@ -218,6 +218,37 @@ public class ChangeEditIT extends AbstractDaemonTest {
assertFalse(beforeRebase.equals(afterRebase)); assertFalse(beforeRebase.equals(afterRebase));
} }
@Test
public void rebaseEditRest() throws Exception {
assertEquals(RefUpdate.Result.NEW,
modifier.createEdit(
change,
ps));
assertEquals(RefUpdate.Result.FORCED,
modifier.modifyFile(
editUtil.byChange(change).get(),
FILE_NAME,
CONTENT_NEW));
ChangeEdit edit = editUtil.byChange(change).get();
PatchSet current = getCurrentPatchSet(changeId);
assertEquals(current.getPatchSetId() - 1,
edit.getBasePatchSet().getPatchSetId());
Date beforeRebase = edit.getEditCommit().getCommitterIdent().getWhen();
RestResponse r = session.post(urlRebase());
assertEquals(SC_NO_CONTENT, r.getStatusCode());
edit = editUtil.byChange(change).get();
assertArrayEquals(CONTENT_NEW,
toBytes(fileUtil.getContent(edit.getChange().getProject(),
edit.getRevision().get(), FILE_NAME)));
assertArrayEquals(CONTENT_NEW2,
toBytes(fileUtil.getContent(edit.getChange().getProject(),
edit.getRevision().get(), FILE_NAME2)));
assertEquals(current.getPatchSetId(),
edit.getBasePatchSet().getPatchSetId());
Date afterRebase = edit.getEditCommit().getCommitterIdent().getWhen();
assertFalse(beforeRebase.equals(afterRebase));
}
@Test @Test
public void updateExistingFile() throws Exception { public void updateExistingFile() throws Exception {
assertEquals(RefUpdate.Result.NEW, assertEquals(RefUpdate.Result.NEW,
@@ -612,6 +643,12 @@ public class ChangeEditIT extends AbstractDaemonTest {
+ "/publish_edit"; + "/publish_edit";
} }
private String urlRebase() {
return "/changes/"
+ change.getChangeId()
+ "/rebase_edit";
}
private EditInfo toEditInfo() throws IOException { private EditInfo toEditInfo() throws IOException {
RestResponse r = session.get(urlEdit()); RestResponse r = session.get(urlEdit());
assertEquals(SC_OK, r.getStatusCode()); assertEquals(SC_OK, r.getStatusCode());

View File

@@ -103,6 +103,7 @@ public class Module extends RestApiModule {
child(CHANGE_KIND, "edit").to(ChangeEdits.class); child(CHANGE_KIND, "edit").to(ChangeEdits.class);
child(CHANGE_KIND, "publish_edit").to(PublishChangeEdit.class); child(CHANGE_KIND, "publish_edit").to(PublishChangeEdit.class);
child(CHANGE_KIND, "rebase_edit").to(RebaseChangeEdit.class);
put(CHANGE_EDIT_KIND, "/").to(ChangeEdits.Put.class); put(CHANGE_EDIT_KIND, "/").to(ChangeEdits.Put.class);
delete(CHANGE_EDIT_KIND).to(ChangeEdits.DeleteContent.class); delete(CHANGE_EDIT_KIND).to(ChangeEdits.DeleteContent.class);
get(CHANGE_EDIT_KIND, "/").to(ChangeEdits.Get.class); get(CHANGE_EDIT_KIND, "/").to(ChangeEdits.Get.class);

View File

@@ -0,0 +1,117 @@
// Copyright (C) 2014 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.change;
import com.google.common.base.Optional;
import com.google.gerrit.extensions.registration.DynamicMap;
import com.google.gerrit.extensions.restapi.AcceptsPost;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.ChildCollection;
import com.google.gerrit.extensions.restapi.IdString;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
import com.google.gerrit.extensions.restapi.Response;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.extensions.restapi.RestModifyView;
import com.google.gerrit.extensions.restapi.RestView;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.edit.ChangeEdit;
import com.google.gerrit.server.edit.ChangeEditModifier;
import com.google.gerrit.server.edit.ChangeEditUtil;
import com.google.gerrit.server.project.InvalidChangeOperationException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
import java.io.IOException;
@Singleton
public class RebaseChangeEdit implements
ChildCollection<ChangeResource, ChangeEditResource>,
AcceptsPost<ChangeResource> {
private final Rebase rebase;
@Inject
RebaseChangeEdit(Rebase rebase) {
this.rebase = rebase;
}
@Override
public DynamicMap<RestView<ChangeEditResource>> views() {
throw new IllegalStateException("not yet implemented");
}
@Override
public RestView<ChangeResource> list() {
throw new IllegalStateException("not yet implemented");
}
@Override
public ChangeEditResource parse(ChangeResource parent, IdString id)
throws ResourceNotFoundException, Exception {
throw new IllegalStateException("not yet implemented");
}
@SuppressWarnings("unchecked")
@Override
public Rebase post(ChangeResource parent) throws RestApiException {
return rebase;
}
@Singleton
public static class Rebase implements RestModifyView<ChangeResource, Publish.Input> {
public static class Input {
}
private final ChangeEditModifier editModifier;
private final ChangeEditUtil editUtil;
private final Provider<ReviewDb> db;
@Inject
Rebase(ChangeEditModifier editModifier,
ChangeEditUtil editUtil,
Provider<ReviewDb> db) {
this.editModifier = editModifier;
this.editUtil = editUtil;
this.db = db;
}
@Override
public Response<?> apply(ChangeResource rsrc, Publish.Input in)
throws AuthException, ResourceConflictException, IOException,
InvalidChangeOperationException, OrmException {
Optional<ChangeEdit> edit = editUtil.byChange(rsrc.getChange());
if (!edit.isPresent()) {
throw new ResourceConflictException(String.format(
"no edit exists for change %s",
rsrc.getChange().getChangeId()));
}
PatchSet current = db.get().patchSets().get(
rsrc.getChange().currentPatchSetId());
if (current.getId().equals(edit.get().getBasePatchSet().getId())) {
throw new ResourceConflictException(String.format(
"edit for change %s is already on latest patch set: %s",
rsrc.getChange().getChangeId(),
current.getId()));
}
editModifier.rebaseEdit(edit.get(), current);
return Response.none();
}
}
}