opendev/gerrit
Code Issues Proposed changes

Merge "Use Collections.addAll to copy elements from an array to collections"

Browse Source
This commit is contained in:
David Pursehouse
2018-05-06 23:35:29 +00:00
committed by Gerrit Code Review
parent 6ad528ae8a 87de0c0622
commit 469bea568d
6 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/acceptance/AbstractDaemonTest.java
View File

@@ -1306,9 +1306,7 @@ public abstract class AbstractDaemonTest {
protected void assertDiffForNewFile(
DiffInfo diff, RevCommit commit, String path, String expectedContentSideB) throws Exception {
List<String> expectedLines = new ArrayList<>();
for (String line : expectedContentSideB.split("\n")) {
expectedLines.add(line);
}
Collections.addAll(expectedLines, expectedContentSideB.split("\n"));
assertThat(diff.binary).isNull();
assertThat(diff.changeType).isEqualTo(ChangeType.ADDED);