From ba6b6d3f480d6c3c60b2deb9b65eecce7f21e178 Mon Sep 17 00:00:00 2001
From: Han-Wen Nienhuys <hanwen@google.com>
Date: Wed, 13 Jan 2021 19:07:57 +0100
Subject: [PATCH] CreateTag: document why we don't check for visibility

Change-Id: I420037ddfc865b5617b73b41ba32f0ec761f3a06
---
 java/com/google/gerrit/server/restapi/project/CreateTag.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/java/com/google/gerrit/server/restapi/project/CreateTag.java b/java/com/google/gerrit/server/restapi/project/CreateTag.java
index 5cfb118d28..b552ff56dd 100644
--- a/java/com/google/gerrit/server/restapi/project/CreateTag.java
+++ b/java/com/google/gerrit/server/restapi/project/CreateTag.java
@@ -102,6 +102,8 @@ public class CreateTag implements RestCollectionCreateView<ProjectResource, TagR
     try (Repository repo = repoManager.openRepository(resource.getNameKey())) {
       ObjectId revid = RefUtil.parseBaseRevision(repo, resource.getNameKey(), input.revision);
       RevWalk rw = RefUtil.verifyConnected(repo, revid);
+      // Reachability through tags does not influence a commit's visibility, so no need to check for
+      // visibility.
       RevObject object = rw.parseAny(revid);
       rw.reset();
       boolean isAnnotated = Strings.emptyToNull(input.message) != null;