opendev
/
gerrit
Code Issues Proposed changes

Fix SuggestBox related deprecation warnings 

We always use the DefaultSuggestionDisplay so its reasonable to
perform the downcast here to that type in order to control the
UI as we want it to behave.

Change-Id: Id48fdaf59ece74abe67773c800f23c3b8312ff3c
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2011-05-19 08:54:16 -07:00
parent d89a18c10b
commit 46cc31adcd
4 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/MyWatchedProjectsScreen.java
View File

@ -41,6 +41,7 @@ import com.google.gwt.user.client.ui.HTMLTable.CellFormatter;
import com.google.gwt.user.client.ui.PopupPanel;
import com.google.gwt.user.client.ui.ScrollPanel;
import com.google.gwt.user.client.ui.SuggestBox;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
import com.google.gwt.user.client.ui.SuggestOracle.Suggestion;
import com.google.gwtexpui.globalkey.client.GlobalKey;
import com.google.gwtexpui.globalkey.client.HidePopupPanelCommand;
@ -173,7 +174,8 @@ public class MyWatchedProjectsScreen extends SettingsScreen implements
submitOnSelection = false;
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
if (((DefaultSuggestionDisplay) nameTxt.getSuggestionDisplay())
.isSuggestionListShowing()) {
submitOnSelection = true;
} else {
doAddNew();

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddIncludedGroupBox.java
View File

@ -28,6 +28,7 @@ import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.SuggestBox;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
import com.google.gwt.user.client.ui.SuggestOracle.Suggestion;
public class AddIncludedGroupBox extends Composite {
@ -52,7 +53,8 @@ public class AddIncludedGroupBox extends Composite {
submitOnSelection = false;
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
if (((DefaultSuggestionDisplay) nameTxt.getSuggestionDisplay())
.isSuggestionListShowing()) {
submitOnSelection = true;
} else {
doAdd();

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java
View File

@ -15,8 +15,6 @@
package com.google.gerrit.client.ui;
import com.google.gerrit.client.admin.Util;
import com.google.gerrit.client.ui.HintTextBox;
import com.google.gerrit.client.ui.RPCSuggestOracle;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyCodes;
@ -28,6 +26,7 @@ import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.SuggestBox;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
import com.google.gwt.user.client.ui.SuggestOracle.Suggestion;
public class AddMemberBox extends Composite {
@ -52,7 +51,8 @@ public class AddMemberBox extends Composite {
submitOnSelection = false;
if (event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) {
if (nameTxt.isSuggestionListShowing()) {
if (((DefaultSuggestionDisplay) nameTxt.getSuggestionDisplay())
.isSuggestionListShowing()) {
submitOnSelection = true;
} else {
doAdd();

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/HintTextBox.java
View File

@ -27,6 +27,7 @@ import com.google.gwt.event.shared.HandlerRegistration;
import com.google.gwtexpui.globalkey.client.NpTextBox;
import com.google.gwt.user.client.ui.SuggestBox;
import com.google.gwt.user.client.ui.Widget;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
public class HintTextBox extends NpTextBox {
@ -152,7 +153,8 @@ public class HintTextBox extends NpTextBox {
((SuggestBox)p).showSuggestionList();
// The suggestion list lingers if we don't hide it.
((SuggestBox)p).hideSuggestionList();
((DefaultSuggestionDisplay) ((SuggestBox) p).getSuggestionDisplay())
.hideSuggestions();
}
setFocus(false);