opendev/gerrit
Code Issues Proposed changes

Fix index template null check

Browse Source 
Because assetsPath is an optional template parameter, it should be
checked for truthiness rather than equality with an empty string. This
caused the run-server.sh tool to fail when rendering the index and it
caused the Java server to incorrectly emit the string "null".

Change-Id: I596d8c88ccf43b7c2fea954110d3b7c5f995dfe3
This commit is contained in:
Wyatt Allen
2018-08-17 17:12:52 -07:00
parent 5d9813454a
commit 4738623fcb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
resources/com/google/gerrit/httpd/raw/PolyGerritIndexHtml.soy
View File

@@ -38,7 +38,7 @@
{if $deprecateGwtUi}window.DEPRECATE_GWT_UI = true;{/if}
{if $versionInfo}window.VERSION_INFO = '{$versionInfo}';{/if}
{if $staticResourcePath != ''}window.STATIC_RESOURCE_PATH = '{$staticResourcePath}';{/if}
{if $assetsPath != ''}window.ASSETS_PATH = '{$assetsPath}';{/if}
{if $assetsPath}window.ASSETS_PATH = '{$assetsPath}';{/if}
</script>{\n}
{if $faviconPath}