opendev/gerrit
Code Issues Proposed changes

Merge "Reload page when change number is clicked"

Browse Source
This commit is contained in:
Wyatt Allen
2016-11-11 01:54:36 +00:00
committed by Gerrit Code Review
parent 6447be010a 3f8f7a51d9
commit 4807acbf50
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@@ -319,6 +319,7 @@
}
var patchChanged = this._patchRange &&
(value.patchNum !== undefined && value.basePatchNum !== undefined) &&
(this._patchRange.patchNum !== value.patchNum ||
this._patchRange.basePatchNum !== value.basePatchNum);

14
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@@ -378,6 +378,20 @@ limitations under the License.
});
test('reload entire page when patchRange doesnt change', function() {
var reloadStub = sandbox.stub(element, '_reload',
function() { return Promise.resolve(); });
var value = {
view: 'gr-change-view',
};
element._paramsChanged(value);
assert.isTrue(reloadStub.calledOnce);
element._initialLoadComplete = true;
element._paramsChanged(value);
assert.isTrue(reloadStub.calledTwice);
});
test('change status new', function() {
element._changeNum = '1';
element._patchRange = {