opendev/gerrit
Code Issues Proposed changes

Merge "Add setTitle function to assign hint message."

Browse Source
This commit is contained in:
viktard
2018-06-19 22:59:55 +00:00
committed by Gerrit Code Review
parent 9429e088e4 5c22266b88
commit 48d52dc68f
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-change-actions-js-api.js
View File

@@ -114,6 +114,11 @@
this._el.setActionButtonProp(key, 'label', text); this._el.setActionButtonProp(key, 'label', text);
}; };
GrChangeActionsInterface.prototype.setTitle = function(key, text) {
ensureEl(this);
this._el.setActionButtonProp(key, 'title', text);
};
GrChangeActionsInterface.prototype.setEnabled = function(key, enabled) { GrChangeActionsInterface.prototype.setEnabled = function(key, enabled) {
ensureEl(this); ensureEl(this);
this._el.setActionButtonProp(key, 'enabled', enabled); this._el.setActionButtonProp(key, 'enabled', enabled);

2
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-change-actions-js-api_test.html
View File

@@ -143,10 +143,12 @@ breaking changes to gr-change-actions won’t be noticed.
assert.equal(button.getAttribute('data-label'), 'Bork!'); assert.equal(button.getAttribute('data-label'), 'Bork!');
assert.isNotOk(button.disabled); assert.isNotOk(button.disabled);
changeActions.setLabel(key, 'Yo'); changeActions.setLabel(key, 'Yo');
changeActions.setTitle(key, 'Yo hint');
changeActions.setEnabled(key, false); changeActions.setEnabled(key, false);
changeActions.setIcon(key, 'pupper'); changeActions.setIcon(key, 'pupper');
flush(() => { flush(() => {
assert.equal(button.getAttribute('data-label'), 'Yo'); assert.equal(button.getAttribute('data-label'), 'Yo');
assert.equal(button.getAttribute('title'), 'Yo hint');
assert.isTrue(button.disabled); assert.isTrue(button.disabled);
assert.equal(Polymer.dom(button).querySelector('iron-icon').icon, assert.equal(Polymer.dom(button).querySelector('iron-icon').icon,
'gr-icons:pupper'); 'gr-icons:pupper');