diff --git a/java/com/google/gerrit/server/change/BatchAbandon.java b/java/com/google/gerrit/server/change/BatchAbandon.java index a8e2407e84..b15db602f3 100644 --- a/java/com/google/gerrit/server/change/BatchAbandon.java +++ b/java/com/google/gerrit/server/change/BatchAbandon.java @@ -22,7 +22,6 @@ import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.account.AccountState; import com.google.gerrit.server.query.change.ChangeData; @@ -30,18 +29,15 @@ import com.google.gerrit.server.update.BatchUpdate; import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.util.Collection; @Singleton public class BatchAbandon { - private final Provider dbProvider; private final AbandonOp.Factory abandonOpFactory; @Inject - BatchAbandon(Provider dbProvider, AbandonOp.Factory abandonOpFactory) { - this.dbProvider = dbProvider; + BatchAbandon(AbandonOp.Factory abandonOpFactory) { this.abandonOpFactory = abandonOpFactory; } @@ -65,7 +61,7 @@ public class BatchAbandon { return; } AccountState accountState = user.isIdentifiedUser() ? user.asIdentifiedUser().state() : null; - try (BatchUpdate u = updateFactory.create(dbProvider.get(), project, user, TimeUtil.nowTs())) { + try (BatchUpdate u = updateFactory.create(project, user, TimeUtil.nowTs())) { for (ChangeData change : changes) { if (!project.equals(change.project())) { throw new ResourceConflictException( diff --git a/java/com/google/gerrit/server/change/ConsistencyChecker.java b/java/com/google/gerrit/server/change/ConsistencyChecker.java index f38d67039d..c819316300 100644 --- a/java/com/google/gerrit/server/change/ConsistencyChecker.java +++ b/java/com/google/gerrit/server/change/ConsistencyChecker.java @@ -37,7 +37,6 @@ import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.reviewdb.server.ReviewDbUtil; import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.CurrentUser; @@ -113,7 +112,6 @@ public class ConsistencyChecker { private final PatchSetUtil psUtil; private final Provider user; private final Provider serverIdent; - private final Provider db; private final RetryHelper retryHelper; private BatchUpdate.Factory updateFactory; @@ -141,11 +139,9 @@ public class ConsistencyChecker { PatchSetInserter.Factory patchSetInserterFactory, PatchSetUtil psUtil, Provider user, - Provider db, RetryHelper retryHelper) { this.accounts = accounts; this.accountPatchReviewStore = accountPatchReviewStore; - this.db = db; this.notesFactory = notesFactory; this.patchSetInfoFactory = patchSetInfoFactory; this.patchSetInserterFactory = patchSetInserterFactory; @@ -585,7 +581,7 @@ public class ConsistencyChecker { } private BatchUpdate newBatchUpdate() { - return updateFactory.create(db.get(), change().getProject(), user.get(), TimeUtil.nowTs()); + return updateFactory.create(change().getProject(), user.get(), TimeUtil.nowTs()); } private void fixPatchSetRef(ProblemInfo p, PatchSet ps) { diff --git a/java/com/google/gerrit/server/edit/ChangeEditUtil.java b/java/com/google/gerrit/server/edit/ChangeEditUtil.java index 0f97ddab46..d6fdf563a5 100644 --- a/java/com/google/gerrit/server/edit/ChangeEditUtil.java +++ b/java/com/google/gerrit/server/edit/ChangeEditUtil.java @@ -27,7 +27,6 @@ import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.RefNames; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.IdentifiedUser; @@ -69,7 +68,6 @@ public class ChangeEditUtil { private final GitRepositoryManager gitManager; private final PatchSetInserter.Factory patchSetInserterFactory; private final ChangeIndexer indexer; - private final Provider db; private final Provider userProvider; private final ChangeKindCache changeKindCache; private final PatchSetUtil psUtil; @@ -79,14 +77,12 @@ public class ChangeEditUtil { GitRepositoryManager gitManager, PatchSetInserter.Factory patchSetInserterFactory, ChangeIndexer indexer, - Provider db, Provider userProvider, ChangeKindCache changeKindCache, PatchSetUtil psUtil) { this.gitManager = gitManager; this.patchSetInserterFactory = patchSetInserterFactory; this.indexer = indexer; - this.db = db; this.userProvider = userProvider; this.changeKindCache = changeKindCache; this.psUtil = psUtil; @@ -201,8 +197,7 @@ public class ChangeEditUtil { .append("."); } - try (BatchUpdate bu = - updateFactory.create(db.get(), change.getProject(), user, TimeUtil.nowTs())) { + try (BatchUpdate bu = updateFactory.create(change.getProject(), user, TimeUtil.nowTs())) { bu.setRepository(repo, rw, oi); bu.addOp(change.getId(), inserter.setMessage(message.toString())); bu.addOp( diff --git a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java index 6896ef94c1..58272998f2 100644 --- a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java +++ b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java @@ -634,7 +634,7 @@ class ReceiveCommits { try (BatchUpdate bu = batchUpdateFactory.create( - db, project.getNameKey(), user.materializedCopy(), TimeUtil.nowTs()); + project.getNameKey(), user.materializedCopy(), TimeUtil.nowTs()); ObjectInserter ins = repo.newObjectInserter(); ObjectReader reader = ins.newReader(); RevWalk rw = new RevWalk(reader)) { @@ -782,7 +782,7 @@ class ReceiveCommits { try (BatchUpdate bu = batchUpdateFactory.create( - db, project.getNameKey(), user.materializedCopy(), TimeUtil.nowTs()); + project.getNameKey(), user.materializedCopy(), TimeUtil.nowTs()); ObjectInserter ins = repo.newObjectInserter(); ObjectReader reader = ins.newReader(); RevWalk rw = new RevWalk(reader)) { @@ -3094,7 +3094,7 @@ class ReceiveCommits { retryHelper.execute( updateFactory -> { try (BatchUpdate bu = - updateFactory.create(db, projectState.getNameKey(), user, TimeUtil.nowTs()); + updateFactory.create(projectState.getNameKey(), user, TimeUtil.nowTs()); ObjectInserter ins = repo.newObjectInserter(); ObjectReader reader = ins.newReader(); RevWalk rw = new RevWalk(reader)) { diff --git a/java/com/google/gerrit/server/mail/receive/MailProcessor.java b/java/com/google/gerrit/server/mail/receive/MailProcessor.java index 8fbce1c50d..a1d745e0f4 100644 --- a/java/com/google/gerrit/server/mail/receive/MailProcessor.java +++ b/java/com/google/gerrit/server/mail/receive/MailProcessor.java @@ -39,7 +39,6 @@ import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchLineComment.Status; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ApprovalsUtil; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.CommentsUtil; @@ -85,7 +84,6 @@ import java.util.Set; public class MailProcessor { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); - private final Provider dbProvider; private final Emails emails; private final InboundEmailRejectionSender.Factory emailRejectionSender; private final RetryHelper retryHelper; @@ -104,7 +102,6 @@ public class MailProcessor { @Inject public MailProcessor( - Provider dbProvider, Emails emails, InboundEmailRejectionSender.Factory emailRejectionSender, RetryHelper retryHelper, @@ -120,7 +117,6 @@ public class MailProcessor { CommentAdded commentAdded, AccountCache accountCache, UrlFormatter urlFormatter) { - this.dbProvider = dbProvider; this.emails = emails; this.emailRejectionSender = emailRejectionSender; this.retryHelper = retryHelper; @@ -263,8 +259,7 @@ public class MailProcessor { } Op o = new Op(new PatchSet.Id(cd.getId(), metadata.patchSet), parsedComments, message.id()); - BatchUpdate batchUpdate = - buf.create(dbProvider.get(), project, ctx.getUser(), TimeUtil.nowTs()); + BatchUpdate batchUpdate = buf.create(project, ctx.getUser(), TimeUtil.nowTs()); batchUpdate.addOp(cd.getId(), o); batchUpdate.execute(); } diff --git a/java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java b/java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java index aab502d3b1..87564abf64 100644 --- a/java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java +++ b/java/com/google/gerrit/server/restapi/account/DeleteDraftComments.java @@ -36,7 +36,6 @@ import com.google.gerrit.reviewdb.client.Account.Id; import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.PatchSetUtil; @@ -74,7 +73,6 @@ import java.util.Objects; public class DeleteDraftComments implements RestModifyView { - private final Provider db; private final Provider userProvider; private final BatchUpdate.Factory batchUpdateFactory; private final Provider queryBuilderProvider; @@ -88,7 +86,6 @@ public class DeleteDraftComments @Inject DeleteDraftComments( - Provider db, Provider userProvider, Factory batchUpdateFactory, Provider queryBuilderProvider, @@ -99,7 +96,6 @@ public class DeleteDraftComments CommentsUtil commentsUtil, PatchSetUtil psUtil, PatchListCache patchListCache) { - this.db = db; this.userProvider = userProvider; this.batchUpdateFactory = batchUpdateFactory; this.queryBuilderProvider = queryBuilderProvider; @@ -142,7 +138,7 @@ public class DeleteDraftComments .query(predicate(accountId, input))) { BatchUpdate update = updates.computeIfAbsent( - cd.project(), p -> batchUpdateFactory.create(db.get(), p, rsrc.getUser(), now)); + cd.project(), p -> batchUpdateFactory.create(p, rsrc.getUser(), now)); Op op = new Op(commentFormatter, accountId); update.addOp(cd.getId(), op); ops.add(op); diff --git a/java/com/google/gerrit/server/restapi/change/Abandon.java b/java/com/google/gerrit/server/restapi/change/Abandon.java index ddb5138ed6..851752d05f 100644 --- a/java/com/google/gerrit/server/restapi/change/Abandon.java +++ b/java/com/google/gerrit/server/restapi/change/Abandon.java @@ -25,7 +25,6 @@ import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.webui.UiAction; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.PatchSetUtil; import com.google.gerrit.server.account.AccountState; @@ -43,7 +42,6 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.io.IOException; import org.eclipse.jgit.errors.ConfigInvalidException; @@ -53,7 +51,6 @@ public class Abandon extends RetryingRestModifyView { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); - private final Provider dbProvider; private final ChangeJson.Factory json; private final AbandonOp.Factory abandonOpFactory; private final NotifyUtil notifyUtil; @@ -61,14 +58,12 @@ public class Abandon extends RetryingRestModifyView dbProvider, ChangeJson.Factory json, RetryHelper retryHelper, AbandonOp.Factory abandonOpFactory, NotifyUtil notifyUtil, PatchSetUtil patchSetUtil) { super(retryHelper); - this.dbProvider = dbProvider; this.json = json; this.abandonOpFactory = abandonOpFactory; this.notifyUtil = notifyUtil; @@ -134,8 +129,7 @@ public class Abandon extends RetryingRestModifyView filesWithGitConflicts(); } - private final Provider dbProvider; private final Sequences seq; private final Provider queryProvider; private final GitRepositoryManager gitManager; @@ -109,7 +107,6 @@ public class CherryPickChange { @Inject CherryPickChange( - Provider dbProvider, Sequences seq, Provider queryProvider, @GerritPersonIdent PersonIdent myIdent, @@ -122,7 +119,6 @@ public class CherryPickChange { ProjectCache projectCache, ApprovalsUtil approvalsUtil, NotifyUtil notifyUtil) { - this.dbProvider = dbProvider; this.seq = seq; this.queryProvider = queryProvider; this.gitManager = gitManager; @@ -248,8 +244,7 @@ public class CherryPickChange { + " reside on the same branch. " + "Cannot create a new patch set."); } - try (BatchUpdate bu = - batchUpdateFactory.create(dbProvider.get(), project, identifiedUser, now)) { + try (BatchUpdate bu = batchUpdateFactory.create(project, identifiedUser, now)) { bu.setRepository(git, revWalk, oi); Change.Id changeId; if (destChanges.size() == 1) { diff --git a/java/com/google/gerrit/server/restapi/change/CreateChange.java b/java/com/google/gerrit/server/restapi/change/CreateChange.java index ba895ce379..af54ed5064 100644 --- a/java/com/google/gerrit/server/restapi/change/CreateChange.java +++ b/java/com/google/gerrit/server/restapi/change/CreateChange.java @@ -39,7 +39,6 @@ import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.RefNames; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.GerritPersonIdent; import com.google.gerrit.server.IdentifiedUser; @@ -101,7 +100,6 @@ public class CreateChange extends RetryingRestCollectionModifyView< TopLevelResource, ChangeResource, ChangeInput, Response> { private final String anonymousCowardName; - private final Provider db; private final GitRepositoryManager gitManager; private final Sequences seq; private final TimeZone serverTimeZone; @@ -122,7 +120,6 @@ public class CreateChange @Inject CreateChange( @AnonymousCowardName String anonymousCowardName, - Provider db, GitRepositoryManager gitManager, Sequences seq, @GerritPersonIdent PersonIdent myIdent, @@ -141,7 +138,6 @@ public class CreateChange ContributorAgreementsChecker contributorAgreements) { super(retryHelper); this.anonymousCowardName = anonymousCowardName; - this.db = db; this.gitManager = gitManager; this.seq = seq; this.serverTimeZone = myIdent.getTimeZone(); @@ -319,7 +315,7 @@ public class CreateChange ins.setGroups(groups); ins.setNotify(input.notify); ins.setAccountsToNotify(notifyUtil.resolveAccounts(input.notifyDetails)); - try (BatchUpdate bu = updateFactory.create(db.get(), project, me, now)) { + try (BatchUpdate bu = updateFactory.create(project, me, now)) { bu.setRepository(git, rw, oi); bu.insertChange(ins); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/CreateDraftComment.java b/java/com/google/gerrit/server/restapi/change/CreateDraftComment.java index bab7fb0fe0..bd51b3e553 100644 --- a/java/com/google/gerrit/server/restapi/change/CreateDraftComment.java +++ b/java/com/google/gerrit/server/restapi/change/CreateDraftComment.java @@ -28,7 +28,6 @@ import com.google.gerrit.extensions.restapi.Url; import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchLineComment.Status; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.PatchSetUtil; import com.google.gerrit.server.change.RevisionResource; @@ -51,7 +50,6 @@ import java.util.Collections; @Singleton public class CreateDraftComment extends RetryingRestModifyView> { - private final Provider db; private final Provider commentJson; private final CommentsUtil commentsUtil; private final PatchSetUtil psUtil; @@ -59,14 +57,12 @@ public class CreateDraftComment @Inject CreateDraftComment( - Provider db, RetryHelper retryHelper, Provider commentJson, CommentsUtil commentsUtil, PatchSetUtil psUtil, PatchListCache patchListCache) { super(retryHelper); - this.db = db; this.commentJson = commentJson; this.commentsUtil = commentsUtil; this.psUtil = psUtil; @@ -88,7 +84,7 @@ public class CreateDraftComment } try (BatchUpdate bu = - updateFactory.create(db.get(), rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { Op op = new Op(rsrc.getPatchSet().getId(), in); bu.addOp(rsrc.getChange().getId(), op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java b/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java index b88d3e9a42..6efe9598b4 100644 --- a/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java +++ b/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java @@ -33,7 +33,6 @@ import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.GerritPersonIdent; @@ -79,7 +78,6 @@ import org.eclipse.jgit.util.ChangeIdUtil; @Singleton public class CreateMergePatchSet extends RetryingRestModifyView> { - private final Provider db; private final GitRepositoryManager gitManager; private final CommitsCollection commits; private final TimeZone serverTimeZone; @@ -94,7 +92,6 @@ public class CreateMergePatchSet @Inject CreateMergePatchSet( - Provider db, GitRepositoryManager gitManager, CommitsCollection commits, @GerritPersonIdent PersonIdent myIdent, @@ -108,7 +105,6 @@ public class CreateMergePatchSet ChangeFinder changeFinder, PermissionBackend permissionBackend) { super(retryHelper); - this.db = db; this.gitManager = gitManager; this.commits = commits; this.serverTimeZone = myIdent.getTimeZone(); @@ -185,7 +181,7 @@ public class CreateMergePatchSet PatchSet.Id nextPsId = ChangeUtil.nextPatchSetId(ps.getId()); PatchSetInserter psInserter = patchSetInserterFactory.create(rsrc.getNotes(), nextPsId, newCommit); - try (BatchUpdate bu = updateFactory.create(db.get(), project, me, now)) { + try (BatchUpdate bu = updateFactory.create(project, me, now)) { bu.setRepository(git, rw, oi); psInserter .setMessage("Uploaded patch set " + nextPsId.get() + ".") diff --git a/java/com/google/gerrit/server/restapi/change/DeleteAssignee.java b/java/com/google/gerrit/server/restapi/change/DeleteAssignee.java index 1e9b69556d..907347f36b 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteAssignee.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteAssignee.java @@ -21,7 +21,6 @@ import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.ChangeMessage; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountLoader; @@ -41,7 +40,6 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; @Singleton @@ -49,7 +47,6 @@ public class DeleteAssignee extends RetryingRestModifyView> { private final ChangeMessagesUtil cmUtil; - private final Provider db; private final AssigneeChanged assigneeChanged; private final IdentifiedUser.GenericFactory userFactory; private final AccountLoader.Factory accountLoaderFactory; @@ -58,13 +55,11 @@ public class DeleteAssignee DeleteAssignee( RetryHelper retryHelper, ChangeMessagesUtil cmUtil, - Provider db, AssigneeChanged assigneeChanged, IdentifiedUser.GenericFactory userFactory, AccountLoader.Factory accountLoaderFactory) { super(retryHelper); this.cmUtil = cmUtil; - this.db = db; this.assigneeChanged = assigneeChanged; this.userFactory = userFactory; this.accountLoaderFactory = accountLoaderFactory; @@ -77,7 +72,7 @@ public class DeleteAssignee rsrc.permissions().check(ChangePermission.EDIT_ASSIGNEE); try (BatchUpdate bu = - updateFactory.create(db.get(), rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { Op op = new Op(); bu.addOp(rsrc.getChange().getId(), op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/DeleteChange.java b/java/com/google/gerrit/server/restapi/change/DeleteChange.java index 3dd7411b49..ce094c6b32 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteChange.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteChange.java @@ -22,7 +22,6 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.webui.UiAction; import com.google.gerrit.reviewdb.client.Change; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.permissions.ChangePermission; import com.google.gerrit.server.permissions.PermissionBackend; @@ -41,14 +40,11 @@ import com.google.inject.Singleton; public class DeleteChange extends RetryingRestModifyView> implements UiAction { - private final Provider db; private final Provider opProvider; @Inject - public DeleteChange( - Provider db, RetryHelper retryHelper, Provider opProvider) { + public DeleteChange(RetryHelper retryHelper, Provider opProvider) { super(retryHelper); - this.db = db; this.opProvider = opProvider; } @@ -62,7 +58,7 @@ public class DeleteChange extends RetryingRestModifyView> { private final Provider userProvider; - private final Provider dbProvider; private final PermissionBackend permissionBackend; private final ChangeMessagesUtil changeMessagesUtil; private final AccountLoader.Factory accountLoaderFactory; @@ -67,7 +65,6 @@ public class DeleteChangeMessage @Inject public DeleteChangeMessage( Provider userProvider, - Provider dbProvider, PermissionBackend permissionBackend, ChangeMessagesUtil changeMessagesUtil, AccountLoader.Factory accountLoaderFactory, @@ -75,7 +72,6 @@ public class DeleteChangeMessage RetryHelper retryHelper) { super(retryHelper); this.userProvider = userProvider; - this.dbProvider = dbProvider; this.permissionBackend = permissionBackend; this.changeMessagesUtil = changeMessagesUtil; this.accountLoaderFactory = accountLoaderFactory; @@ -97,8 +93,7 @@ public class DeleteChangeMessage DeleteChangeMessageOp deleteChangeMessageOp = new DeleteChangeMessageOp(resource.getChangeMessageIndex(), newChangeMessage); try (BatchUpdate batchUpdate = - updateFactory.create( - dbProvider.get(), resource.getChangeResource().getProject(), user, TimeUtil.nowTs())) { + updateFactory.create(resource.getChangeResource().getProject(), user, TimeUtil.nowTs())) { batchUpdate.addOp(resource.getChangeId(), deleteChangeMessageOp).execute(); } diff --git a/java/com/google/gerrit/server/restapi/change/DeleteComment.java b/java/com/google/gerrit/server/restapi/change/DeleteComment.java index 6279357aba..e73c4f3dbe 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteComment.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteComment.java @@ -22,7 +22,6 @@ import com.google.gerrit.extensions.restapi.ResourceNotFoundException; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.change.CommentResource; @@ -51,7 +50,6 @@ public class DeleteComment extends RetryingRestModifyView { private final Provider userProvider; - private final Provider dbProvider; private final PermissionBackend permissionBackend; private final CommentsUtil commentsUtil; private final Provider commentJson; @@ -60,7 +58,6 @@ public class DeleteComment @Inject public DeleteComment( Provider userProvider, - Provider dbProvider, PermissionBackend permissionBackend, RetryHelper retryHelper, CommentsUtil commentsUtil, @@ -68,7 +65,6 @@ public class DeleteComment ChangeNotes.Factory notesFactory) { super(retryHelper); this.userProvider = userProvider; - this.dbProvider = dbProvider; this.permissionBackend = permissionBackend; this.commentsUtil = commentsUtil; this.commentJson = commentJson; @@ -91,7 +87,7 @@ public class DeleteComment DeleteCommentOp deleteCommentOp = new DeleteCommentOp(rsrc, newMessage); try (BatchUpdate batchUpdate = batchUpdateFactory.create( - dbProvider.get(), rsrc.getRevisionResource().getProject(), user, TimeUtil.nowTs())) { + rsrc.getRevisionResource().getProject(), user, TimeUtil.nowTs())) { batchUpdate.addOp(rsrc.getRevisionResource().getChange().getId(), deleteCommentOp).execute(); } diff --git a/java/com/google/gerrit/server/restapi/change/DeleteDraftComment.java b/java/com/google/gerrit/server/restapi/change/DeleteDraftComment.java index 0e62273ffa..efdd4470a4 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteDraftComment.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteDraftComment.java @@ -23,7 +23,6 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.PatchSetUtil; import com.google.gerrit.server.change.DraftCommentResource; @@ -38,7 +37,6 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.util.Collections; import java.util.Optional; @@ -47,20 +45,17 @@ import java.util.Optional; public class DeleteDraftComment extends RetryingRestModifyView> { - private final Provider db; private final CommentsUtil commentsUtil; private final PatchSetUtil psUtil; private final PatchListCache patchListCache; @Inject DeleteDraftComment( - Provider db, CommentsUtil commentsUtil, PatchSetUtil psUtil, RetryHelper retryHelper, PatchListCache patchListCache) { super(retryHelper); - this.db = db; this.commentsUtil = commentsUtil; this.psUtil = psUtil; this.patchListCache = patchListCache; @@ -71,8 +66,7 @@ public class DeleteDraftComment BatchUpdate.Factory updateFactory, DraftCommentResource rsrc, Input input) throws RestApiException, UpdateException { try (BatchUpdate bu = - updateFactory.create( - db.get(), rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { Op op = new Op(rsrc.getComment().key); bu.addOp(rsrc.getChange().getId(), op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/DeletePrivate.java b/java/com/google/gerrit/server/restapi/change/DeletePrivate.java index 9b747e072d..571c3190d8 100644 --- a/java/com/google/gerrit/server/restapi/change/DeletePrivate.java +++ b/java/com/google/gerrit/server/restapi/change/DeletePrivate.java @@ -21,7 +21,6 @@ import com.google.gerrit.extensions.restapi.AuthException; import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.permissions.GlobalPermission; @@ -32,26 +31,22 @@ import com.google.gerrit.server.update.RetryingRestModifyView; import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; @Singleton public class DeletePrivate extends RetryingRestModifyView> { private final ChangeMessagesUtil cmUtil; - private final Provider dbProvider; private final PermissionBackend permissionBackend; private final SetPrivateOp.Factory setPrivateOpFactory; @Inject DeletePrivate( - Provider dbProvider, RetryHelper retryHelper, ChangeMessagesUtil cmUtil, PermissionBackend permissionBackend, SetPrivateOp.Factory setPrivateOpFactory) { super(retryHelper); - this.dbProvider = dbProvider; this.cmUtil = cmUtil; this.permissionBackend = permissionBackend; this.setPrivateOpFactory = setPrivateOpFactory; @@ -71,8 +66,7 @@ public class DeletePrivate SetPrivateOp op = setPrivateOpFactory.create(cmUtil, false, input); try (BatchUpdate u = - updateFactory.create( - dbProvider.get(), rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { u.addOp(rsrc.getId(), op).execute(); } diff --git a/java/com/google/gerrit/server/restapi/change/DeletePrivateByPost.java b/java/com/google/gerrit/server/restapi/change/DeletePrivateByPost.java index cf0143ac04..6404256709 100644 --- a/java/com/google/gerrit/server/restapi/change/DeletePrivateByPost.java +++ b/java/com/google/gerrit/server/restapi/change/DeletePrivateByPost.java @@ -17,25 +17,22 @@ package com.google.gerrit.server.restapi.change; import static com.google.gerrit.extensions.conditions.BooleanCondition.and; import com.google.gerrit.extensions.webui.UiAction; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.update.RetryHelper; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; @Singleton public class DeletePrivateByPost extends DeletePrivate implements UiAction { @Inject DeletePrivateByPost( - Provider dbProvider, RetryHelper retryHelper, ChangeMessagesUtil cmUtil, PermissionBackend permissionBackend, SetPrivateOp.Factory setPrivateOpFactory) { - super(dbProvider, retryHelper, cmUtil, permissionBackend, setPrivateOpFactory); + super(retryHelper, cmUtil, permissionBackend, setPrivateOpFactory); } @Override diff --git a/java/com/google/gerrit/server/restapi/change/DeleteReviewer.java b/java/com/google/gerrit/server/restapi/change/DeleteReviewer.java index 245d1cdf58..da1679c849 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteReviewer.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteReviewer.java @@ -17,7 +17,6 @@ package com.google.gerrit.server.restapi.change; import com.google.gerrit.extensions.api.changes.DeleteReviewerInput; import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.change.ReviewerResource; import com.google.gerrit.server.update.BatchUpdate; import com.google.gerrit.server.update.BatchUpdateOp; @@ -26,25 +25,21 @@ import com.google.gerrit.server.update.RetryingRestModifyView; import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; @Singleton public class DeleteReviewer extends RetryingRestModifyView> { - private final Provider dbProvider; private final DeleteReviewerOp.Factory deleteReviewerOpFactory; private final DeleteReviewerByEmailOp.Factory deleteReviewerByEmailOpFactory; @Inject DeleteReviewer( - Provider dbProvider, RetryHelper retryHelper, DeleteReviewerOp.Factory deleteReviewerOpFactory, DeleteReviewerByEmailOp.Factory deleteReviewerByEmailOpFactory) { super(retryHelper); - this.dbProvider = dbProvider; this.deleteReviewerOpFactory = deleteReviewerOpFactory; this.deleteReviewerByEmailOpFactory = deleteReviewerByEmailOpFactory; } @@ -59,7 +54,6 @@ public class DeleteReviewer try (BatchUpdate bu = updateFactory.create( - dbProvider.get(), rsrc.getChangeResource().getProject(), rsrc.getChangeResource().getUser(), TimeUtil.nowTs())) { diff --git a/java/com/google/gerrit/server/restapi/change/DeleteVote.java b/java/com/google/gerrit/server/restapi/change/DeleteVote.java index 8aaf458826..60d11633e5 100644 --- a/java/com/google/gerrit/server/restapi/change/DeleteVote.java +++ b/java/com/google/gerrit/server/restapi/change/DeleteVote.java @@ -31,7 +31,6 @@ import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.ChangeMessage; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.PatchSetApproval; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ApprovalsUtil; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.IdentifiedUser; @@ -58,7 +57,6 @@ import com.google.gerrit.server.util.LabelVote; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.io.IOException; import java.util.HashMap; @@ -68,7 +66,6 @@ import java.util.Map; public class DeleteVote extends RetryingRestModifyView> { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); - private final Provider db; private final ApprovalsUtil approvalsUtil; private final PatchSetUtil psUtil; private final ChangeMessagesUtil cmUtil; @@ -81,7 +78,6 @@ public class DeleteVote extends RetryingRestModifyView db, RetryHelper retryHelper, ApprovalsUtil approvalsUtil, PatchSetUtil psUtil, @@ -93,7 +89,6 @@ public class DeleteVote extends RetryingRestModifyView dbProvider; private final ChangeJson.Factory json; private final GitRepositoryManager repoManager; private final Provider queryProvider; @@ -95,7 +93,6 @@ public class Move extends RetryingRestModifyView dbProvider, ChangeJson.Factory json, GitRepositoryManager repoManager, Provider queryProvider, @@ -107,7 +104,6 @@ public class Move extends RetryingRestModifyView>> implements UiAction { - private final Provider db; private final SetHashtagsOp.Factory hashtagsFactory; @Inject - PostHashtags( - Provider db, RetryHelper retryHelper, SetHashtagsOp.Factory hashtagsFactory) { + PostHashtags(RetryHelper retryHelper, SetHashtagsOp.Factory hashtagsFactory) { super(retryHelper); - this.db = db; this.hashtagsFactory = hashtagsFactory; } @@ -56,8 +51,7 @@ public class PostHashtags req.permissions().check(ChangePermission.EDIT_HASHTAGS); try (BatchUpdate bu = - updateFactory.create( - db.get(), req.getChange().getProject(), req.getUser(), TimeUtil.nowTs())) { + updateFactory.create(req.getChange().getProject(), req.getUser(), TimeUtil.nowTs())) { SetHashtagsOp op = hashtagsFactory.create(input); bu.addOp(req.getId(), op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/PostPrivate.java b/java/com/google/gerrit/server/restapi/change/PostPrivate.java index 3f37bc1c0f..b1a250c997 100644 --- a/java/com/google/gerrit/server/restapi/change/PostPrivate.java +++ b/java/com/google/gerrit/server/restapi/change/PostPrivate.java @@ -24,7 +24,6 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.webui.UiAction; import com.google.gerrit.reviewdb.client.Change; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.config.GerritServerConfig; @@ -36,7 +35,6 @@ import com.google.gerrit.server.update.RetryingRestModifyView; import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import org.eclipse.jgit.lib.Config; @@ -45,21 +43,18 @@ public class PostPrivate extends RetryingRestModifyView> implements UiAction { private final ChangeMessagesUtil cmUtil; - private final Provider dbProvider; private final PermissionBackend permissionBackend; private final SetPrivateOp.Factory setPrivateOpFactory; private final boolean disablePrivateChanges; @Inject PostPrivate( - Provider dbProvider, RetryHelper retryHelper, ChangeMessagesUtil cmUtil, PermissionBackend permissionBackend, SetPrivateOp.Factory setPrivateOpFactory, @GerritServerConfig Config config) { super(retryHelper); - this.dbProvider = dbProvider; this.cmUtil = cmUtil; this.permissionBackend = permissionBackend; this.setPrivateOpFactory = setPrivateOpFactory; @@ -84,8 +79,7 @@ public class PostPrivate SetPrivateOp op = setPrivateOpFactory.create(cmUtil, true, input); try (BatchUpdate u = - updateFactory.create( - dbProvider.get(), rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { u.addOp(rsrc.getId(), op).execute(); } diff --git a/java/com/google/gerrit/server/restapi/change/PostReview.java b/java/com/google/gerrit/server/restapi/change/PostReview.java index d627166a51..90e420840e 100644 --- a/java/com/google/gerrit/server/restapi/change/PostReview.java +++ b/java/com/google/gerrit/server/restapi/change/PostReview.java @@ -76,7 +76,6 @@ import com.google.gerrit.reviewdb.client.PatchLineComment.Status; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.PatchSetApproval; import com.google.gerrit.reviewdb.client.RobotComment; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ApprovalsUtil; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.ChangeUtil; @@ -124,7 +123,6 @@ import com.google.gerrit.server.util.time.TimeUtil; import com.google.gson.Gson; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.io.IOException; import java.nio.charset.StandardCharsets; @@ -158,7 +156,6 @@ public class PostReview private static final Gson GSON = OutputFormat.JSON_COMPACT.newGson(); private static final int DEFAULT_ROBOT_COMMENT_SIZE_LIMIT_IN_BYTES = 1024 * 1024; - private final Provider db; private final ChangeResource.Factory changeResourceFactory; private final ChangeData.Factory changeDataFactory; private final ApprovalsUtil approvalsUtil; @@ -181,7 +178,6 @@ public class PostReview @Inject PostReview( - Provider db, RetryHelper retryHelper, ChangeResource.Factory changeResourceFactory, ChangeData.Factory changeDataFactory, @@ -202,7 +198,6 @@ public class PostReview ProjectCache projectCache, PermissionBackend permissionBackend) { super(retryHelper); - this.db = db; this.changeResourceFactory = changeResourceFactory; this.changeDataFactory = changeDataFactory; this.commentsUtil = commentsUtil; @@ -303,7 +298,7 @@ public class PostReview output.labels = input.labels; try (BatchUpdate bu = - updateFactory.create(db.get(), revision.getChange().getProject(), revision.getUser(), ts)) { + updateFactory.create(revision.getChange().getProject(), revision.getUser(), ts)) { Account.Id id = revision.getUser().getAccountId(); boolean ccOrReviewer = false; if (input.labels != null && !input.labels.isEmpty()) { diff --git a/java/com/google/gerrit/server/restapi/change/PostReviewers.java b/java/com/google/gerrit/server/restapi/change/PostReviewers.java index fd823a87b8..fdfefabb2c 100644 --- a/java/com/google/gerrit/server/restapi/change/PostReviewers.java +++ b/java/com/google/gerrit/server/restapi/change/PostReviewers.java @@ -19,7 +19,6 @@ import com.google.gerrit.extensions.api.changes.AddReviewerResult; import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Change; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.change.ChangeResource; import com.google.gerrit.server.change.ReviewerAdder; import com.google.gerrit.server.change.ReviewerAdder.ReviewerAddition; @@ -33,7 +32,6 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.io.IOException; import org.eclipse.jgit.errors.ConfigInvalidException; @@ -43,18 +41,13 @@ public class PostReviewers extends RetryingRestCollectionModifyView< ChangeResource, ReviewerResource, AddReviewerInput, AddReviewerResult> { - private final Provider dbProvider; private final ChangeData.Factory changeDataFactory; private final ReviewerAdder reviewerAdder; @Inject PostReviewers( - Provider db, - ChangeData.Factory changeDataFactory, - RetryHelper retryHelper, - ReviewerAdder reviewerAdder) { + ChangeData.Factory changeDataFactory, RetryHelper retryHelper, ReviewerAdder reviewerAdder) { super(retryHelper); - this.dbProvider = db; this.changeDataFactory = changeDataFactory; this.reviewerAdder = reviewerAdder; } @@ -73,8 +66,7 @@ public class PostReviewers return addition.result; } try (BatchUpdate bu = - updateFactory.create( - dbProvider.get(), rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getProject(), rsrc.getUser(), TimeUtil.nowTs())) { Change.Id id = rsrc.getChange().getId(); bu.addOp(id, addition.op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/PutAssignee.java b/java/com/google/gerrit/server/restapi/change/PutAssignee.java index bdec929754..982b3e6b88 100644 --- a/java/com/google/gerrit/server/restapi/change/PutAssignee.java +++ b/java/com/google/gerrit/server/restapi/change/PutAssignee.java @@ -25,7 +25,6 @@ import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.UnprocessableEntityException; import com.google.gerrit.extensions.webui.UiAction; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountLoader; import com.google.gerrit.server.account.AccountResolver; @@ -43,7 +42,6 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import java.io.IOException; import org.eclipse.jgit.errors.ConfigInvalidException; @@ -54,7 +52,6 @@ public class PutAssignee extends RetryingRestModifyView db; private final ReviewerAdder reviewerAdder; private final AccountLoader.Factory accountLoaderFactory; private final PermissionBackend permissionBackend; @@ -64,14 +61,12 @@ public class PutAssignee extends RetryingRestModifyView db, ReviewerAdder reviewerAdder, AccountLoader.Factory accountLoaderFactory, PermissionBackend permissionBackend) { super(retryHelper); this.accountResolver = accountResolver; this.assigneeFactory = assigneeFactory; - this.db = db; this.reviewerAdder = reviewerAdder; this.accountLoaderFactory = accountLoaderFactory; this.permissionBackend = permissionBackend; @@ -103,8 +98,7 @@ public class PutAssignee extends RetryingRestModifyView> implements UiAction { - private final Provider dbProvider; private final ChangeMessagesUtil cmUtil; private final PatchSetUtil psUtil; @Inject - PutDescription( - Provider dbProvider, - ChangeMessagesUtil cmUtil, - RetryHelper retryHelper, - PatchSetUtil psUtil) { + PutDescription(ChangeMessagesUtil cmUtil, RetryHelper retryHelper, PatchSetUtil psUtil) { super(retryHelper); - this.dbProvider = dbProvider; this.cmUtil = cmUtil; this.psUtil = psUtil; } @@ -68,8 +60,7 @@ public class PutDescription Op op = new Op(input != null ? input : new DescriptionInput(), rsrc.getPatchSet().getId()); try (BatchUpdate u = - updateFactory.create( - dbProvider.get(), rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { u.addOp(rsrc.getChange().getId(), op); u.execute(); } diff --git a/java/com/google/gerrit/server/restapi/change/PutDraftComment.java b/java/com/google/gerrit/server/restapi/change/PutDraftComment.java index 76fb889ea3..25fa5d76f0 100644 --- a/java/com/google/gerrit/server/restapi/change/PutDraftComment.java +++ b/java/com/google/gerrit/server/restapi/change/PutDraftComment.java @@ -26,7 +26,6 @@ import com.google.gerrit.extensions.restapi.Url; import com.google.gerrit.reviewdb.client.Comment; import com.google.gerrit.reviewdb.client.PatchLineComment.Status; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.PatchSetUtil; import com.google.gerrit.server.change.DraftCommentResource; @@ -53,7 +52,6 @@ import java.util.Optional; public class PutDraftComment extends RetryingRestModifyView> { - private final Provider db; private final DeleteDraftComment delete; private final CommentsUtil commentsUtil; private final PatchSetUtil psUtil; @@ -62,7 +60,6 @@ public class PutDraftComment @Inject PutDraftComment( - Provider db, DeleteDraftComment delete, CommentsUtil commentsUtil, PatchSetUtil psUtil, @@ -70,7 +67,6 @@ public class PutDraftComment Provider commentJson, PatchListCache patchListCache) { super(retryHelper); - this.db = db; this.delete = delete; this.commentsUtil = commentsUtil; this.psUtil = psUtil; @@ -93,8 +89,7 @@ public class PutDraftComment } try (BatchUpdate bu = - updateFactory.create( - db.get(), rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { + updateFactory.create(rsrc.getChange().getProject(), rsrc.getUser(), TimeUtil.nowTs())) { Op op = new Op(rsrc.getComment().key, in); bu.addOp(rsrc.getChange().getId(), op); bu.execute(); diff --git a/java/com/google/gerrit/server/restapi/change/PutMessage.java b/java/com/google/gerrit/server/restapi/change/PutMessage.java index 541fabdfe1..80d0aba2f0 100644 --- a/java/com/google/gerrit/server/restapi/change/PutMessage.java +++ b/java/com/google/gerrit/server/restapi/change/PutMessage.java @@ -24,7 +24,6 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.BooleanProjectConfig; import com.google.gerrit.reviewdb.client.PatchSet; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.GerritPersonIdent; @@ -68,7 +67,6 @@ public class PutMessage private final GitRepositoryManager repositoryManager; private final Provider userProvider; - private final Provider db; private final TimeZone tz; private final PatchSetInserter.Factory psInserterFactory; private final PermissionBackend permissionBackend; @@ -81,7 +79,6 @@ public class PutMessage RetryHelper retryHelper, GitRepositoryManager repositoryManager, Provider userProvider, - Provider db, PatchSetInserter.Factory psInserterFactory, PermissionBackend permissionBackend, @GerritPersonIdent PersonIdent gerritIdent, @@ -91,7 +88,6 @@ public class PutMessage super(retryHelper); this.repositoryManager = repositoryManager; this.userProvider = userProvider; - this.db = db; this.psInserterFactory = psInserterFactory; this.tz = gerritIdent.getTimeZone(); this.permissionBackend = permissionBackend; @@ -138,8 +134,7 @@ public class PutMessage Timestamp ts = TimeUtil.nowTs(); try (BatchUpdate bu = - updateFactory.create( - db.get(), resource.getChange().getProject(), userProvider.get(), ts)) { + updateFactory.create(resource.getChange().getProject(), userProvider.get(), ts)) { // Ensure that BatchUpdate will update the same repo bu.setRepository(repository, new RevWalk(objectInserter.newReader()), objectInserter); diff --git a/java/com/google/gerrit/server/restapi/change/PutTopic.java b/java/com/google/gerrit/server/restapi/change/PutTopic.java index 60d50882ee..bc272e95ef 100644 --- a/java/com/google/gerrit/server/restapi/change/PutTopic.java +++ b/java/com/google/gerrit/server/restapi/change/PutTopic.java @@ -22,7 +22,6 @@ import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.webui.UiAction; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.ChangeMessage; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.ChangeMessagesUtil; import com.google.gerrit.server.ChangeUtil; import com.google.gerrit.server.change.ChangeResource; @@ -40,24 +39,17 @@ import com.google.gerrit.server.update.UpdateException; import com.google.gerrit.server.util.time.TimeUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; @Singleton public class PutTopic extends RetryingRestModifyView> implements UiAction { - private final Provider dbProvider; private final ChangeMessagesUtil cmUtil; private final TopicEdited topicEdited; @Inject - PutTopic( - Provider dbProvider, - ChangeMessagesUtil cmUtil, - RetryHelper retryHelper, - TopicEdited topicEdited) { + PutTopic(ChangeMessagesUtil cmUtil, RetryHelper retryHelper, TopicEdited topicEdited) { super(retryHelper); - this.dbProvider = dbProvider; this.cmUtil = cmUtil; this.topicEdited = topicEdited; } @@ -82,8 +74,7 @@ public class PutTopic extends RetryingRestModifyView dbProvider; private final PermissionBackend permissionBackend; private final ProjectCache projectCache; private final PatchSetUtil patchSetUtil; @@ -86,7 +83,6 @@ public class Rebase extends RetryingRestModifyView dbProvider, PermissionBackend permissionBackend, ProjectCache projectCache, PatchSetUtil patchSetUtil) { @@ -95,7 +91,6 @@ public class Rebase extends RetryingRestModifyView dbProvider; private final ChangeJson.Factory json; private final ChangeMessagesUtil cmUtil; private final PatchSetUtil psUtil; @@ -68,7 +65,6 @@ public class Restore extends RetryingRestModifyView dbProvider, ChangeJson.Factory json, ChangeMessagesUtil cmUtil, PatchSetUtil psUtil, @@ -77,7 +73,6 @@ public class Restore extends RetryingRestModifyView { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); - private final Provider db; private final PermissionBackend permissionBackend; private final GitRepositoryManager repoManager; private final ChangeInserter.Factory changeInserterFactory; @@ -110,7 +108,6 @@ public class Revert extends RetryingRestModifyView db, PermissionBackend permissionBackend, GitRepositoryManager repoManager, ChangeInserter.Factory changeInserterFactory, @@ -127,7 +124,6 @@ public class Revert extends RetryingRestModifyView> implements UiAction { private final WorkInProgressOp.Factory opFactory; - private final Provider db; private final PermissionBackend permissionBackend; private final Provider user; @@ -54,12 +52,10 @@ public class SetReadyForReview extends RetryingRestModifyView db, PermissionBackend permissionBackend, Provider user) { super(retryHelper); this.opFactory = opFactory; - this.db = db; this.permissionBackend = permissionBackend; this.user = user; } @@ -80,7 +76,7 @@ public class SetReadyForReview extends RetryingRestModifyView> implements UiAction { private final WorkInProgressOp.Factory opFactory; - private final Provider db; private final PermissionBackend permissionBackend; private final Provider user; @@ -54,12 +52,10 @@ public class SetWorkInProgress extends RetryingRestModifyView db, PermissionBackend permissionBackend, Provider user) { super(retryHelper); this.opFactory = opFactory; - this.db = db; this.permissionBackend = permissionBackend; this.user = user; } @@ -80,7 +76,7 @@ public class SetWorkInProgress extends RetryingRestModifyView metaDataUpdateFactory; - private final Provider db; private final SetAccessUtil setAccess; private final ChangeJson.Factory jsonFactory; private final ProjectCache projectCache; @@ -77,7 +75,6 @@ public class CreateAccessChange implements RestModifyView metaDataUpdateFactory, - Provider db, SetAccessUtil accessUtil, ChangeJson.Factory jsonFactory, ProjectCache projectCache, @@ -87,7 +84,6 @@ public class CreateAccessChange implements RestModifyView getRef(String name) throws Exception { diff --git a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java index 65609c8e46..ed26bc2f18 100644 --- a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java +++ b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java @@ -2969,7 +2969,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { new Project.NameKey(repo.getRepository().getDescription().getRepositoryName()); Account.Id ownerId = owner != null ? owner : userId; IdentifiedUser user = userFactory.create(ownerId); - try (BatchUpdate bu = updateFactory.create(db, project, user, createdOn)) { + try (BatchUpdate bu = updateFactory.create(project, user, createdOn)) { bu.insertChange(ins); bu.execute(); return ins.getChange(); @@ -2989,7 +2989,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { .setNotify(NotifyHandling.NONE) .setFireRevisionCreated(false) .setValidate(false); - try (BatchUpdate bu = updateFactory.create(db, c.getProject(), user, TimeUtil.nowTs()); + try (BatchUpdate bu = updateFactory.create(c.getProject(), user, TimeUtil.nowTs()); ObjectInserter oi = repo.getRepository().newObjectInserter(); ObjectReader reader = oi.newReader(); RevWalk rw = new RevWalk(reader)) { diff --git a/javatests/com/google/gerrit/server/update/BatchUpdateTest.java b/javatests/com/google/gerrit/server/update/BatchUpdateTest.java index 7f8e1f444a..2ae0a5fd77 100644 --- a/javatests/com/google/gerrit/server/update/BatchUpdateTest.java +++ b/javatests/com/google/gerrit/server/update/BatchUpdateTest.java @@ -17,7 +17,6 @@ package com.google.gerrit.server.update; import static org.junit.Assert.assertEquals; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.git.GitRepositoryManager; import com.google.gerrit.server.util.time.TimeUtil; @@ -37,7 +36,6 @@ public class BatchUpdateTest extends GerritBaseTests { @Inject private GitRepositoryManager repoManager; @Inject private BatchUpdate.Factory batchUpdateFactory; - @Inject private ReviewDb db; @Inject private Provider user; private Project.NameKey project; @@ -56,7 +54,7 @@ public class BatchUpdateTest extends GerritBaseTests { final RevCommit masterCommit = repo.branch("master").commit().create(); final RevCommit branchCommit = repo.branch("branch").commit().parent(masterCommit).create(); - try (BatchUpdate bu = batchUpdateFactory.create(db, project, user.get(), TimeUtil.nowTs())) { + try (BatchUpdate bu = batchUpdateFactory.create(project, user.get(), TimeUtil.nowTs())) { bu.addRepoOnlyOp( new RepoOnlyOp() { @Override