opendev/gerrit
Code Issues Proposed changes

Test that auto-close by commit on direct push adds change message

Browse Source 
On auto-close by commit Gerrit informs about the auto-close by adding a
change message to the change.

Auto-close by Change-Id should add the same message but it doesn't. This
should be fixed separately.

Change-Id: Icfe6c0e0e9656427f8c7ef02d12b61e5f1df1076
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin 2018-01-04 10:10:05 +01:00
parent edb636cda1
commit 49c12bdd1b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java
View File

@ -320,6 +320,11 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest {
String url = canonicalWebUrl.get() + "#/c/" + project.get() + "/+/" + r.getChange().getId();
r = amendChange(r.getChangeId(), "refs/for/master");
r.assertErrorStatus("change " + url + " closed");
// Check change message that was added on auto-close
ChangeInfo change = gApi.changes().id(r.getChange().getId().get()).get();
assertThat(Iterables.getLast(change.messages).message)
.isEqualTo("Change has been successfully pushed.");
}
@Test