From 49fc8fe7d22a9c93d71e71bae8eb3a5415d952a0 Mon Sep 17 00:00:00 2001 From: Gustaf Lundh Date: Thu, 11 Sep 2014 17:56:37 +0200 Subject: [PATCH] Make hashtags clickable Change-Id: I802c8a0e0bcdb0b3dce69b6ea4e68b9a36660e8a --- .../java/com/google/gerrit/client/change/Hashtags.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java index 0d5b943db3..0cc3ced433 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java @@ -159,17 +159,20 @@ public class Hashtags extends Composite { while (itr.hasNext()) { String hashtagName = itr.next(); html.openSpan() - .setAttribute("role", "listitem") .setAttribute(DATA_ID, hashtagName) .setStyleName(style.hashtagName()) + .openAnchor() + .setAttribute("href", "#" + PageLinks.toChangeQuery("hashtag:" + hashtagName)) + .setAttribute("role", "listitem") .append(hashtagName) + .closeAnchor() .openElement("button") .setAttribute("title", "Remove hashtag") .setAttribute("onclick", REMOVE + "(event)") .append( new ImageResourceRenderer().render(Resources.I.remove_reviewer())) - .closeElement("button"); - html.closeSpan(); + .closeElement("button") + .closeSpan(); if (itr.hasNext()) { html.append(' '); }