opendev/gerrit
Code Issues Proposed changes

Delete unused setDest() in MergedSender

Browse Source 
We moved the private instance member this used to populate, as it was
never read (and is thus dead code). But we forgot to also delete the
now-dead setter.

Change-Id: I5ef5897c58f32c88908c5134ef8221b1d938f970
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2011-05-19 11:58:47 -07:00
parent acb213efa9
commit 4c4e822e8a
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@ -1879,8 +1879,6 @@ public class ReceiveCommits implements PreReceiveHook, PostReceiveHook {
final MergedSender cm = mergedSenderFactory.create(result.change); final MergedSender cm = mergedSenderFactory.create(result.change);
cm.setFrom(currentUser.getAccountId()); cm.setFrom(currentUser.getAccountId());
cm.setPatchSet(result.patchSet, result.info); cm.setPatchSet(result.patchSet, result.info);
cm.setDest(new Branch.NameKey(project.getNameKey(),
result.mergedIntoRef));
cm.send(); cm.send();
} catch (EmailException e) { } catch (EmailException e) {
final PatchSet.Id psi = result.patchSet.getId(); final PatchSet.Id psi = result.patchSet.getId();

6
gerrit-server/src/main/java/com/google/gerrit/server/mail/MergedSender.java
View File

@ -18,12 +18,11 @@ import com.google.gerrit.common.data.ApprovalType;
import com.google.gerrit.common.data.ApprovalTypes; import com.google.gerrit.common.data.ApprovalTypes;
import com.google.gerrit.reviewdb.Account; import com.google.gerrit.reviewdb.Account;
import com.google.gerrit.reviewdb.AccountProjectWatch; import com.google.gerrit.reviewdb.AccountProjectWatch;
import com.google.gerrit.reviewdb.AccountProjectWatch.NotifyType;
import com.google.gerrit.reviewdb.ApprovalCategory; import com.google.gerrit.reviewdb.ApprovalCategory;
import com.google.gerrit.reviewdb.ApprovalCategoryValue; import com.google.gerrit.reviewdb.ApprovalCategoryValue;
import com.google.gerrit.reviewdb.Branch;
import com.google.gerrit.reviewdb.Change; import com.google.gerrit.reviewdb.Change;
import com.google.gerrit.reviewdb.PatchSetApproval; import com.google.gerrit.reviewdb.PatchSetApproval;
import com.google.gerrit.reviewdb.AccountProjectWatch.NotifyType;
import com.google.gwtorm.client.OrmException; import com.google.gwtorm.client.OrmException;
import com.google.inject.Inject; import com.google.inject.Inject;
import com.google.inject.assistedinject.Assisted; import com.google.inject.assistedinject.Assisted;
@ -45,9 +44,6 @@ public class MergedSender extends ReplyToChangeSender {
approvalTypes = at; approvalTypes = at;
} }
public void setDest(final Branch.NameKey key) {
}
@Override @Override
protected void init() throws EmailException { protected void init() throws EmailException {
super.init(); super.init();