diff --git a/java/com/google/gerrit/acceptance/AbstractNotificationTest.java b/java/com/google/gerrit/acceptance/AbstractNotificationTest.java index ab887fe7c1..8333005b29 100644 --- a/java/com/google/gerrit/acceptance/AbstractNotificationTest.java +++ b/java/com/google/gerrit/acceptance/AbstractNotificationTest.java @@ -35,7 +35,7 @@ import com.google.gerrit.extensions.client.GeneralPreferencesInfo; import com.google.gerrit.extensions.client.GeneralPreferencesInfo.EmailStrategy; import com.google.gerrit.extensions.client.InheritableBoolean; import com.google.gerrit.extensions.client.ReviewerState; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.Address; import com.google.gerrit.server.mail.send.EmailHeader; import com.google.gerrit.server.mail.send.EmailHeader.AddressList; diff --git a/java/com/google/gerrit/server/account/AccountConfig.java b/java/com/google/gerrit/server/account/AccountConfig.java index 9513791346..8e6b01ca64 100644 --- a/java/com/google/gerrit/server/account/AccountConfig.java +++ b/java/com/google/gerrit/server/account/AccountConfig.java @@ -27,8 +27,8 @@ import com.google.gerrit.extensions.client.EditPreferencesInfo; import com.google.gerrit.extensions.client.GeneralPreferencesInfo; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.RefNames; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.account.externalids.ExternalIds; import com.google.gerrit.server.git.MetaDataUpdate; import com.google.gerrit.server.git.ValidationError; @@ -88,12 +88,12 @@ import org.eclipse.jgit.revwalk.RevSort; * doesn't exist). * *

The preferences are stored in a 'preferences.config' config file. Parsing and updating it is - * implemented by {@link PreferencesConfig} and this class delegates the handling of preferences to - * {@link PreferencesConfig}. + * implemented by {@link Preferences} and this class delegates the handling of preferences to {@link + * Preferences}. * *

The project watches are stored in a 'watch.config' config file. Parsing and updating it is - * implemented by {@link WatchConfig} and this class delegates the handling of project watches to - * {@link WatchConfig}. + * implemented by {@link ProjectWatches} and this class delegates the handling of project watches to + * {@link ProjectWatches}. * *

By default preferences and project watches are lazily parsed on need. Eager parsing can be * requested by {@link #setEagerParsing(boolean)}. @@ -112,8 +112,8 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. private Optional loadedAccount; private Optional externalIdsRev; - private WatchConfig watchConfig; - private PreferencesConfig prefConfig; + private ProjectWatches projectWatches; + private Preferences preferences; private Optional accountUpdate = Optional.empty(); private Timestamp registeredOn; private boolean eagerParsing; @@ -183,7 +183,7 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. */ public ImmutableMap> getProjectWatches() { checkLoaded(); - return watchConfig.getProjectWatches(); + return projectWatches.getProjectWatches(); } /** @@ -193,7 +193,7 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. */ public GeneralPreferencesInfo getGeneralPreferences() { checkLoaded(); - return prefConfig.getGeneralPreferences(); + return preferences.getGeneralPreferences(); } /** @@ -203,7 +203,7 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. */ public DiffPreferencesInfo getDiffPreferences() { checkLoaded(); - return prefConfig.getDiffPreferences(); + return preferences.getDiffPreferences(); } /** @@ -213,7 +213,7 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. */ public EditPreferencesInfo getEditPreferences() { checkLoaded(); - return prefConfig.getEditPreferences(); + return preferences.getEditPreferences(); } /** @@ -281,27 +281,26 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. Config accountConfig = readConfig(ACCOUNT_CONFIG); loadedAccount = Optional.of(parse(accountConfig, revision.name())); - watchConfig = new WatchConfig(accountId, readConfig(WatchConfig.WATCH_CONFIG), this); + projectWatches = new ProjectWatches(accountId, readConfig(ProjectWatches.WATCH_CONFIG), this); - prefConfig = - new PreferencesConfig( + preferences = + new Preferences( accountId, - readConfig(PreferencesConfig.PREFERENCES_CONFIG), - PreferencesConfig.readDefaultConfig(repo), + readConfig(Preferences.PREFERENCES_CONFIG), + Preferences.readDefaultConfig(repo), this); if (eagerParsing) { - watchConfig.parse(); - prefConfig.parse(); + projectWatches.parse(); + preferences.parse(); } } else { loadedAccount = Optional.empty(); - watchConfig = new WatchConfig(accountId, new Config(), this); + projectWatches = new ProjectWatches(accountId, new Config(), this); - prefConfig = - new PreferencesConfig( - accountId, new Config(), PreferencesConfig.readDefaultConfig(repo), this); + preferences = + new Preferences(accountId, new Config(), Preferences.readDefaultConfig(repo), this); } Ref externalIdsRef = repo.exactRef(RefNames.REFS_EXTERNAL_IDS); @@ -383,14 +382,14 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. if (accountUpdate.isPresent() && (!accountUpdate.get().getDeletedProjectWatches().isEmpty() || !accountUpdate.get().getUpdatedProjectWatches().isEmpty())) { - Map> projectWatches = - new HashMap<>(watchConfig.getProjectWatches()); - accountUpdate.get().getDeletedProjectWatches().forEach(pw -> projectWatches.remove(pw)); + Map> newProjectWatches = + new HashMap<>(projectWatches.getProjectWatches()); + accountUpdate.get().getDeletedProjectWatches().forEach(pw -> newProjectWatches.remove(pw)); accountUpdate .get() .getUpdatedProjectWatches() - .forEach((pw, nt) -> projectWatches.put(pw, nt)); - saveConfig(WatchConfig.WATCH_CONFIG, watchConfig.save(projectWatches)); + .forEach((pw, nt) -> newProjectWatches.put(pw, nt)); + saveConfig(ProjectWatches.WATCH_CONFIG, projectWatches.save(newProjectWatches)); } } @@ -403,8 +402,8 @@ public class AccountConfig extends VersionedMetaData implements ValidationError. } saveConfig( - PreferencesConfig.PREFERENCES_CONFIG, - prefConfig.saveGeneralPreferences( + Preferences.PREFERENCES_CONFIG, + preferences.saveGeneralPreferences( accountUpdate.get().getGeneralPreferences(), accountUpdate.get().getDiffPreferences(), accountUpdate.get().getEditPreferences())); diff --git a/java/com/google/gerrit/server/account/AccountState.java b/java/com/google/gerrit/server/account/AccountState.java index 8bd12c03f7..b5348456ae 100644 --- a/java/com/google/gerrit/server/account/AccountState.java +++ b/java/com/google/gerrit/server/account/AccountState.java @@ -31,8 +31,8 @@ import com.google.gerrit.extensions.client.GeneralPreferencesInfo; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.server.CurrentUser.PropertyKey; import com.google.gerrit.server.IdentifiedUser; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.account.externalids.ExternalId; import com.google.gerrit.server.account.externalids.ExternalIdNotes; import com.google.gerrit.server.account.externalids.ExternalIds; diff --git a/java/com/google/gerrit/server/account/AccountsUpdate.java b/java/com/google/gerrit/server/account/AccountsUpdate.java index 694b37aefe..6729b86f24 100644 --- a/java/com/google/gerrit/server/account/AccountsUpdate.java +++ b/java/com/google/gerrit/server/account/AccountsUpdate.java @@ -83,8 +83,8 @@ import org.eclipse.jgit.lib.Repository; * The timestamp of the first commit on a user branch denotes the registration date. The initial * commit on the user branch may be empty (since having an 'account.config' is optional). See {@link * AccountConfig} for details of the 'account.config' file format. In addition the user branch can - * contain a 'preferences.config' config file to store preferences (see {@link PreferencesConfig}) - * and a 'watch.config' config file to store project watches (see {@link WatchConfig}). External IDs + * contain a 'preferences.config' config file to store preferences (see {@link Preferences}) and a + * 'watch.config' config file to store project watches (see {@link ProjectWatches}). External IDs * are stored separately in the {@code refs/meta/external-ids} notes branch (see {@link * ExternalIdNotes}). * diff --git a/java/com/google/gerrit/server/account/InternalAccountUpdate.java b/java/com/google/gerrit/server/account/InternalAccountUpdate.java index 4549ebf768..c778fca17c 100644 --- a/java/com/google/gerrit/server/account/InternalAccountUpdate.java +++ b/java/com/google/gerrit/server/account/InternalAccountUpdate.java @@ -22,8 +22,8 @@ import com.google.gerrit.extensions.client.DiffPreferencesInfo; import com.google.gerrit.extensions.client.EditPreferencesInfo; import com.google.gerrit.extensions.client.GeneralPreferencesInfo; import com.google.gerrit.reviewdb.client.Account; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.account.externalids.DuplicateExternalIdKeyException; import com.google.gerrit.server.account.externalids.ExternalId; import java.util.Collection; diff --git a/java/com/google/gerrit/server/account/PreferencesConfig.java b/java/com/google/gerrit/server/account/Preferences.java similarity index 99% rename from java/com/google/gerrit/server/account/PreferencesConfig.java rename to java/com/google/gerrit/server/account/Preferences.java index 71f9e04b68..d0301d1a05 100644 --- a/java/com/google/gerrit/server/account/PreferencesConfig.java +++ b/java/com/google/gerrit/server/account/Preferences.java @@ -85,8 +85,8 @@ import org.slf4j.LoggerFactory; * *

The preferences are lazily parsed. */ -public class PreferencesConfig { - private static final Logger log = LoggerFactory.getLogger(PreferencesConfig.class); +public class Preferences { + private static final Logger log = LoggerFactory.getLogger(Preferences.class); public static final String PREFERENCES_CONFIG = "preferences.config"; @@ -99,7 +99,7 @@ public class PreferencesConfig { private DiffPreferencesInfo diffPreferences; private EditPreferencesInfo editPreferences; - public PreferencesConfig( + public Preferences( Account.Id accountId, Config cfg, Config defaultCfg, diff --git a/java/com/google/gerrit/server/account/WatchConfig.java b/java/com/google/gerrit/server/account/ProjectWatches.java similarity index 97% rename from java/com/google/gerrit/server/account/WatchConfig.java rename to java/com/google/gerrit/server/account/ProjectWatches.java index 0c9b3bec54..1587e48e40 100644 --- a/java/com/google/gerrit/server/account/WatchConfig.java +++ b/java/com/google/gerrit/server/account/ProjectWatches.java @@ -76,11 +76,11 @@ import org.eclipse.jgit.lib.Config; * *

The project watches are lazily parsed. */ -public class WatchConfig { +public class ProjectWatches { @AutoValue public abstract static class ProjectWatchKey { public static ProjectWatchKey create(Project.NameKey project, @Nullable String filter) { - return new AutoValue_WatchConfig_ProjectWatchKey(project, Strings.emptyToNull(filter)); + return new AutoValue_ProjectWatches_ProjectWatchKey(project, Strings.emptyToNull(filter)); } public abstract Project.NameKey project(); @@ -111,7 +111,8 @@ public class WatchConfig { private ImmutableMap> projectWatches; - public WatchConfig(Account.Id accountId, Config cfg, ValidationError.Sink validationErrorSink) { + public ProjectWatches( + Account.Id accountId, Config cfg, ValidationError.Sink validationErrorSink) { this.accountId = checkNotNull(accountId, "accountId"); this.cfg = checkNotNull(cfg, "cfg"); this.validationErrorSink = checkNotNull(validationErrorSink, "validationErrorSink"); @@ -256,7 +257,7 @@ public class WatchConfig { } public static NotifyValue create(@Nullable String filter, Collection notifyTypes) { - return new AutoValue_WatchConfig_NotifyValue( + return new AutoValue_ProjectWatches_NotifyValue( Strings.emptyToNull(filter), Sets.immutableEnumSet(notifyTypes)); } diff --git a/java/com/google/gerrit/server/git/NotifyConfig.java b/java/com/google/gerrit/server/git/NotifyConfig.java index 55b94e5875..d2d3a39226 100644 --- a/java/com/google/gerrit/server/git/NotifyConfig.java +++ b/java/com/google/gerrit/server/git/NotifyConfig.java @@ -16,7 +16,7 @@ package com.google.gerrit.server.git; import com.google.common.base.Strings; import com.google.gerrit.common.data.GroupReference; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.Address; import java.util.EnumSet; import java.util.HashSet; diff --git a/java/com/google/gerrit/server/git/ProjectConfig.java b/java/com/google/gerrit/server/git/ProjectConfig.java index 629e7f6153..abef5a8f48 100644 --- a/java/com/google/gerrit/server/git/ProjectConfig.java +++ b/java/com/google/gerrit/server/git/ProjectConfig.java @@ -47,7 +47,7 @@ import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.RefNames; import com.google.gerrit.server.account.GroupBackend; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.config.ConfigUtil; import com.google.gerrit.server.config.PluginConfig; import com.google.gerrit.server.mail.Address; diff --git a/java/com/google/gerrit/server/mail/send/AbandonedSender.java b/java/com/google/gerrit/server/mail/send/AbandonedSender.java index ec62833472..05dd54250c 100644 --- a/java/com/google/gerrit/server/mail/send/AbandonedSender.java +++ b/java/com/google/gerrit/server/mail/send/AbandonedSender.java @@ -17,7 +17,7 @@ package com.google.gerrit.server.mail.send; import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/mail/send/ChangeEmail.java b/java/com/google/gerrit/server/mail/send/ChangeEmail.java index 3e1dc92c1c..0aad9c9c7b 100644 --- a/java/com/google/gerrit/server/mail/send/ChangeEmail.java +++ b/java/com/google/gerrit/server/mail/send/ChangeEmail.java @@ -30,7 +30,7 @@ import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.StarredChangesUtil; import com.google.gerrit.server.account.AccountState; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.send.ProjectWatch.Watchers; import com.google.gerrit.server.notedb.ReviewerStateInternal; import com.google.gerrit.server.patch.PatchList; diff --git a/java/com/google/gerrit/server/mail/send/CommentSender.java b/java/com/google/gerrit/server/mail/send/CommentSender.java index 805527300f..0247fc39ef 100644 --- a/java/com/google/gerrit/server/mail/send/CommentSender.java +++ b/java/com/google/gerrit/server/mail/send/CommentSender.java @@ -28,7 +28,7 @@ import com.google.gerrit.reviewdb.client.Patch; import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.reviewdb.client.RobotComment; import com.google.gerrit.server.CommentsUtil; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.mail.MailUtil; import com.google.gerrit.server.mail.receive.Protocol; diff --git a/java/com/google/gerrit/server/mail/send/CreateChangeSender.java b/java/com/google/gerrit/server/mail/send/CreateChangeSender.java index 8956f10133..10d14a8c5e 100644 --- a/java/com/google/gerrit/server/mail/send/CreateChangeSender.java +++ b/java/com/google/gerrit/server/mail/send/CreateChangeSender.java @@ -20,7 +20,7 @@ import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.server.IdentifiedUser; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.send.ProjectWatch.Watchers; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.permissions.RefPermission; diff --git a/java/com/google/gerrit/server/mail/send/DeleteReviewerSender.java b/java/com/google/gerrit/server/mail/send/DeleteReviewerSender.java index 0fea7cec14..c434d068f4 100644 --- a/java/com/google/gerrit/server/mail/send/DeleteReviewerSender.java +++ b/java/com/google/gerrit/server/mail/send/DeleteReviewerSender.java @@ -19,7 +19,7 @@ import com.google.gerrit.extensions.api.changes.RecipientType; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.Address; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; diff --git a/java/com/google/gerrit/server/mail/send/DeleteVoteSender.java b/java/com/google/gerrit/server/mail/send/DeleteVoteSender.java index 8509f73528..0c81293ba6 100644 --- a/java/com/google/gerrit/server/mail/send/DeleteVoteSender.java +++ b/java/com/google/gerrit/server/mail/send/DeleteVoteSender.java @@ -17,7 +17,7 @@ package com.google.gerrit.server.mail.send; import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/mail/send/MergedSender.java b/java/com/google/gerrit/server/mail/send/MergedSender.java index 425ac655cd..cf9257ca72 100644 --- a/java/com/google/gerrit/server/mail/send/MergedSender.java +++ b/java/com/google/gerrit/server/mail/send/MergedSender.java @@ -24,7 +24,7 @@ import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSetApproval; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/mail/send/NotificationEmail.java b/java/com/google/gerrit/server/mail/send/NotificationEmail.java index c192dfa25f..3fefac4c5b 100644 --- a/java/com/google/gerrit/server/mail/send/NotificationEmail.java +++ b/java/com/google/gerrit/server/mail/send/NotificationEmail.java @@ -19,7 +19,7 @@ import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.extensions.api.changes.RecipientType; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Branch; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gerrit.server.mail.Address; import com.google.gerrit.server.mail.send.ProjectWatch.Watchers; import com.google.gwtorm.server.OrmException; diff --git a/java/com/google/gerrit/server/mail/send/ProjectWatch.java b/java/com/google/gerrit/server/mail/send/ProjectWatch.java index 93ed4f136a..5b361f1efd 100644 --- a/java/com/google/gerrit/server/mail/send/ProjectWatch.java +++ b/java/com/google/gerrit/server/mail/send/ProjectWatch.java @@ -26,8 +26,8 @@ import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountState; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.git.NotifyConfig; import com.google.gerrit.server.mail.Address; import com.google.gerrit.server.project.ProjectState; diff --git a/java/com/google/gerrit/server/mail/send/ReplacePatchSetSender.java b/java/com/google/gerrit/server/mail/send/ReplacePatchSetSender.java index c9e5791f5a..2398b82b3b 100644 --- a/java/com/google/gerrit/server/mail/send/ReplacePatchSetSender.java +++ b/java/com/google/gerrit/server/mail/send/ReplacePatchSetSender.java @@ -20,7 +20,7 @@ import com.google.gerrit.extensions.api.changes.RecipientType; import com.google.gerrit.reviewdb.client.Account; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/mail/send/RestoredSender.java b/java/com/google/gerrit/server/mail/send/RestoredSender.java index 6076b46afc..d7f8eb5293 100644 --- a/java/com/google/gerrit/server/mail/send/RestoredSender.java +++ b/java/com/google/gerrit/server/mail/send/RestoredSender.java @@ -17,7 +17,7 @@ package com.google.gerrit.server.mail.send; import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/mail/send/RevertedSender.java b/java/com/google/gerrit/server/mail/send/RevertedSender.java index c4c0a69ebf..21703a33cf 100644 --- a/java/com/google/gerrit/server/mail/send/RevertedSender.java +++ b/java/com/google/gerrit/server/mail/send/RevertedSender.java @@ -17,7 +17,7 @@ package com.google.gerrit.server.mail.send; import com.google.gerrit.common.errors.EmailException; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; -import com.google.gerrit.server.account.WatchConfig.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.assistedinject.Assisted; diff --git a/java/com/google/gerrit/server/query/change/IsWatchedByPredicate.java b/java/com/google/gerrit/server/query/change/IsWatchedByPredicate.java index 90eb8e4235..0e6e2a21b8 100644 --- a/java/com/google/gerrit/server/query/change/IsWatchedByPredicate.java +++ b/java/com/google/gerrit/server/query/change/IsWatchedByPredicate.java @@ -20,7 +20,7 @@ import com.google.gerrit.index.query.Predicate; import com.google.gerrit.index.query.QueryBuilder; import com.google.gerrit.index.query.QueryParseException; import com.google.gerrit.server.CurrentUser; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; diff --git a/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java b/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java index 5a1f6bf672..464f85db10 100644 --- a/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java +++ b/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java @@ -26,7 +26,7 @@ import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountResource; import com.google.gerrit.server.account.AccountsUpdate; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.permissions.GlobalPermission; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.permissions.PermissionBackendException; diff --git a/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java b/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java index 460d072a6f..389dc0ea6b 100644 --- a/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java +++ b/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java @@ -26,8 +26,8 @@ import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountResource; import com.google.gerrit.server.account.AccountState; import com.google.gerrit.server.account.Accounts; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.permissions.GlobalPermission; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.permissions.PermissionBackendException; diff --git a/java/com/google/gerrit/server/restapi/account/PostWatchedProjects.java b/java/com/google/gerrit/server/restapi/account/PostWatchedProjects.java index 435d9e495a..143586086e 100644 --- a/java/com/google/gerrit/server/restapi/account/PostWatchedProjects.java +++ b/java/com/google/gerrit/server/restapi/account/PostWatchedProjects.java @@ -21,9 +21,9 @@ import com.google.gerrit.extensions.restapi.RestModifyView; import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.account.AccountResource; import com.google.gerrit.server.account.AccountsUpdate; -import com.google.gerrit.server.account.WatchConfig; -import com.google.gerrit.server.account.WatchConfig.NotifyType; -import com.google.gerrit.server.account.WatchConfig.ProjectWatchKey; +import com.google.gerrit.server.account.ProjectWatches; +import com.google.gerrit.server.account.ProjectWatches.NotifyType; +import com.google.gerrit.server.account.ProjectWatches.ProjectWatchKey; import com.google.gerrit.server.permissions.GlobalPermission; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.permissions.PermissionBackendException; @@ -124,6 +124,8 @@ public class PostWatchedProjects private static String format(String project, String filter) { return project - + (filter != null && !WatchConfig.FILTER_ALL.equals(filter) ? " and filter " + filter : ""); + + (filter != null && !ProjectWatches.FILTER_ALL.equals(filter) + ? " and filter " + filter + : ""); } } diff --git a/java/com/google/gerrit/server/restapi/account/SetPreferences.java b/java/com/google/gerrit/server/restapi/account/SetPreferences.java index 8131748989..1e8e7c9df0 100644 --- a/java/com/google/gerrit/server/restapi/account/SetPreferences.java +++ b/java/com/google/gerrit/server/restapi/account/SetPreferences.java @@ -26,7 +26,7 @@ import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.account.AccountCache; import com.google.gerrit.server.account.AccountResource; import com.google.gerrit.server.account.AccountsUpdate; -import com.google.gerrit.server.account.PreferencesConfig; +import com.google.gerrit.server.account.Preferences; import com.google.gerrit.server.permissions.GlobalPermission; import com.google.gerrit.server.permissions.PermissionBackend; import com.google.gerrit.server.permissions.PermissionBackendException; @@ -68,7 +68,7 @@ public class SetPreferences implements RestModifyView { public DiffPreferencesInfo apply(ConfigResource configResource) throws BadRequestException, ResourceConflictException, IOException, ConfigInvalidException { try (Repository git = gitManager.openRepository(allUsersName)) { - return PreferencesConfig.readDefaultDiffPreferences(git); + return Preferences.readDefaultDiffPreferences(git); } } } diff --git a/java/com/google/gerrit/server/restapi/config/GetEditPreferences.java b/java/com/google/gerrit/server/restapi/config/GetEditPreferences.java index bd8174e1a7..44466d31a6 100644 --- a/java/com/google/gerrit/server/restapi/config/GetEditPreferences.java +++ b/java/com/google/gerrit/server/restapi/config/GetEditPreferences.java @@ -18,7 +18,7 @@ import com.google.gerrit.extensions.client.EditPreferencesInfo; import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.ResourceConflictException; import com.google.gerrit.extensions.restapi.RestReadView; -import com.google.gerrit.server.account.PreferencesConfig; +import com.google.gerrit.server.account.Preferences; import com.google.gerrit.server.config.AllUsersName; import com.google.gerrit.server.config.ConfigResource; import com.google.gerrit.server.git.GitRepositoryManager; @@ -43,7 +43,7 @@ public class GetEditPreferences implements RestReadView { public EditPreferencesInfo apply(ConfigResource configResource) throws BadRequestException, ResourceConflictException, IOException, ConfigInvalidException { try (Repository git = gitManager.openRepository(allUsersName)) { - return PreferencesConfig.readDefaultEditPreferences(git); + return Preferences.readDefaultEditPreferences(git); } } } diff --git a/java/com/google/gerrit/server/restapi/config/GetPreferences.java b/java/com/google/gerrit/server/restapi/config/GetPreferences.java index e81ce24ac2..e0c54d47ed 100644 --- a/java/com/google/gerrit/server/restapi/config/GetPreferences.java +++ b/java/com/google/gerrit/server/restapi/config/GetPreferences.java @@ -16,7 +16,7 @@ package com.google.gerrit.server.restapi.config; import com.google.gerrit.extensions.client.GeneralPreferencesInfo; import com.google.gerrit.extensions.restapi.RestReadView; -import com.google.gerrit.server.account.PreferencesConfig; +import com.google.gerrit.server.account.Preferences; import com.google.gerrit.server.config.AllUsersName; import com.google.gerrit.server.config.ConfigResource; import com.google.gerrit.server.git.GitRepositoryManager; @@ -41,7 +41,7 @@ public class GetPreferences implements RestReadView { public GeneralPreferencesInfo apply(ConfigResource rsrc) throws IOException, ConfigInvalidException { try (Repository git = gitMgr.openRepository(allUsersName)) { - return PreferencesConfig.readDefaultGeneralPreferences(git); + return Preferences.readDefaultGeneralPreferences(git); } } } diff --git a/java/com/google/gerrit/server/restapi/config/SetDiffPreferences.java b/java/com/google/gerrit/server/restapi/config/SetDiffPreferences.java index ca7b73955c..1f6feb4cd4 100644 --- a/java/com/google/gerrit/server/restapi/config/SetDiffPreferences.java +++ b/java/com/google/gerrit/server/restapi/config/SetDiffPreferences.java @@ -22,7 +22,7 @@ import com.google.gerrit.extensions.client.DiffPreferencesInfo; import com.google.gerrit.extensions.restapi.BadRequestException; import com.google.gerrit.extensions.restapi.RestModifyView; import com.google.gerrit.server.account.AccountCache; -import com.google.gerrit.server.account.PreferencesConfig; +import com.google.gerrit.server.account.Preferences; import com.google.gerrit.server.config.AllUsersName; import com.google.gerrit.server.config.ConfigResource; import com.google.gerrit.server.git.MetaDataUpdate; @@ -65,7 +65,7 @@ public class SetDiffPreferences implements RestModifyView> projectWatches = - WatchConfig.parse(new Account.Id(1000000), cfg, this); + ProjectWatches.parse(new Account.Id(1000000), cfg, this); assertThat(validationErrors).isEmpty(); @@ -87,7 +87,7 @@ public class WatchConfigTest implements ValidationError.Sink { + "[project \"otherProject\"]\n" + " notify = [NEW_PATCHSETS]\n"); - WatchConfig.parse(new Account.Id(1000000), cfg, this); + ProjectWatches.parse(new Account.Id(1000000), cfg, this); assertThat(validationErrors).hasSize(1); assertThat(validationErrors.get(0).getMessage()) .isEqualTo(