-
-
-
-
+ on-response="_handleDiffResponse">
+
+
+
+
diff --git a/polygerrit-ui/app/elements/gr-file-list.html b/polygerrit-ui/app/elements/gr-file-list.html
index 1a5dcf05a9..1b0e932785 100644
--- a/polygerrit-ui/app/elements/gr-file-list.html
+++ b/polygerrit-ui/app/elements/gr-file-list.html
@@ -46,8 +46,7 @@ limitations under the License.
+ on-response="_handleResponse">
diff --git a/polygerrit-ui/app/elements/gr-message.html b/polygerrit-ui/app/elements/gr-message.html
index c0770a0904..f105501ea9 100644
--- a/polygerrit-ui/app/elements/gr-message.html
+++ b/polygerrit-ui/app/elements/gr-message.html
@@ -15,7 +15,7 @@ limitations under the License.
-->
-
+
@@ -25,7 +25,7 @@ limitations under the License.
display: block;
position: relative;
}
- :host:not([expanded]) {
+ :host(:not([expanded])) {
cursor: pointer;
}
.avatar {
diff --git a/polygerrit-ui/app/elements/gr-messages-list.html b/polygerrit-ui/app/elements/gr-messages-list.html
index 7771ef4882..add285ddec 100644
--- a/polygerrit-ui/app/elements/gr-messages-list.html
+++ b/polygerrit-ui/app/elements/gr-messages-list.html
@@ -15,7 +15,7 @@ limitations under the License.
-->
-
+
diff --git a/polygerrit-ui/app/scripts/app.js b/polygerrit-ui/app/scripts/app.js
index ac9ee7d495..70140743e8 100644
--- a/polygerrit-ui/app/scripts/app.js
+++ b/polygerrit-ui/app/scripts/app.js
@@ -53,6 +53,12 @@
patchNum: ctx.params[4],
path: ctx.params[5]
};
+ // Don't allow diffing the same patch number against itself because WHY?
+ if (params.basePatchNum == params.patchNum) {
+ page.redirect('/c/' + params.changeNum + '/' + params.patchNum + '/' +
+ params.path);
+ return;
+ }
if (!params.patchNum) {
params.patchNum = params.basePatchNum;
delete(params.basePatchNum);
diff --git a/polygerrit-ui/app/test/gr-diff-comment-test.html b/polygerrit-ui/app/test/gr-diff-comment-test.html
new file mode 100644
index 0000000000..e67337166b
--- /dev/null
+++ b/polygerrit-ui/app/test/gr-diff-comment-test.html
@@ -0,0 +1,57 @@
+
+
+
+
+gr-diff-comment
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/polygerrit-ui/app/test/gr-diff-comment-thread-test.html b/polygerrit-ui/app/test/gr-diff-comment-thread-test.html
new file mode 100644
index 0000000000..c0a1358efc
--- /dev/null
+++ b/polygerrit-ui/app/test/gr-diff-comment-thread-test.html
@@ -0,0 +1,118 @@
+
+
+
+
+gr-diff-comment-thread
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/polygerrit-ui/app/test/gr-diff-view-test.html b/polygerrit-ui/app/test/gr-diff-view-test.html
index e33aee8f1c..a615d82138 100644
--- a/polygerrit-ui/app/test/gr-diff-view-test.html
+++ b/polygerrit-ui/app/test/gr-diff-view-test.html
@@ -16,7 +16,7 @@ limitations under the License.
-->
-gr-diff
+gr-diff-view
@@ -28,14 +28,22 @@ limitations under the License.
+
+
+
+
+
+
+