opendev/gerrit
Code Issues Proposed changes

Fix: The file column's left border does't appear.

Browse Source 
In Unified view the left border line of patch content
is lost.

This commit fixed it.

Change-Id: I9e874fa8a85373e71bc26a8f298c39b0b805a896
This commit is contained in:
Bruce Zu
2012-10-23 15:56:49 +08:00
parent 29caf967ec
commit 4d26617509
4 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritCss.java
View File

@@ -189,6 +189,7 @@ public interface GerritCss extends CssResource {
String sectionHeader();
String sideBySideScreenLinkTable();
String sideBySideScreenSideBySideTable();
String unifiedTable();
String singleLine();
String skipLine();
String smallHeading();

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css
View File

@@ -1048,6 +1048,13 @@ a:hover.downloadLink {
padding-left: 0px;
}
/** UnifiedScreen **/
.unifiedTable {
width: 100%;
border: 1px solid #B0BDCC;
display: table;
}
/** SideBySideScreen **/
.sideBySideScreenSideBySideTable {
width: 100%;

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
View File

@@ -330,8 +330,13 @@ public abstract class PatchScreen extends Screen implements
add(topNav);
contentPanel = new FlowPanel();
contentPanel.setStyleName(Gerrit.RESOURCES.css()
.sideBySideScreenSideBySideTable());
if (getPatchScreenType() == PatchScreen.Type.SIDE_BY_SIDE) {
contentPanel.setStyleName(//
Gerrit.RESOURCES.css().sideBySideScreenSideBySideTable());
} else {
contentPanel.setStyleName(Gerrit.RESOURCES.css().unifiedTable());
}
contentPanel.add(header);
contentPanel.add(noDifference);
contentPanel.add(contentTable);

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedDiffTable.java
View File

@@ -274,6 +274,7 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
padLineNumberForSideB(m);
m.openTd();
m.setStyleName(Gerrit.RESOURCES.css().fileLine());
m.addStyleName(Gerrit.RESOURCES.css().diffText());
m.addStyleName(Gerrit.RESOURCES.css().diffTextFileHeader());
m.append(line);
@@ -287,6 +288,7 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
padLineNumberForSideB(m);
m.openTd();
m.setStyleName(Gerrit.RESOURCES.css().fileLine());
m.addStyleName(Gerrit.RESOURCES.css().diffText());
m.addStyleName(Gerrit.RESOURCES.css().diffTextHunkHeader());
m.append("@@ -");
@@ -324,6 +326,7 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
final SparseHtmlFile src, final int i) {
final SafeHtml text = src.getSafeHtmlLine(i);
m.openTd();
m.setStyleName(Gerrit.RESOURCES.css().fileLine());
m.addStyleName(Gerrit.RESOURCES.css().diffText());
switch (type) {
case CONTEXT: