opendev/gerrit
Code Issues Proposed changes

Merge "SideBySide2: Document Ctrl-F/Ctrl-B shortcuts"

Browse Source
This commit is contained in:
Edwin Kempin
2014-01-17 06:57:49 +00:00
committed by Gerrit Code Review
parent 943286552b 6cc62d29ea
commit 4d2b368625
4 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/intro-change-screen.txt
View File

@@ -178,7 +178,9 @@ region on one line to emphasize what the comment is related to.
Key bindings: Key bindings:
* j / k: next line / previous line
* n / p: next diff chunk / previous diff chunk * n / p: next diff chunk / previous diff chunk
* <Ctrl> + f / <Ctrl> + b: next page / previous page
* ] / [: next file / previous file * ] / [: next file / previous file
* u: up to change * u: up to change
* c: create a new inline comment (focus has to be in codemirror view) * c: create a new inline comment (focus has to be in codemirror view)

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java
View File

@@ -401,6 +401,9 @@ public class SideBySide2 extends Screen {
keysNavigation.add( keysNavigation.add(
new NoOpKeyCommand(KeyCommand.M_SHIFT, 'n', PatchUtil.C.commentNext()), new NoOpKeyCommand(KeyCommand.M_SHIFT, 'n', PatchUtil.C.commentNext()),
new NoOpKeyCommand(KeyCommand.M_SHIFT, 'p', PatchUtil.C.commentPrev())); new NoOpKeyCommand(KeyCommand.M_SHIFT, 'p', PatchUtil.C.commentPrev()));
keysNavigation.add(
new NoOpKeyCommand(KeyCommand.M_CTRL, 'f', PatchUtil.C.pageNext()),
new NoOpKeyCommand(KeyCommand.M_CTRL, 'b', PatchUtil.C.pagePrev()));
keysAction = new KeyCommandSet(Gerrit.C.sectionActions()); keysAction = new KeyCommandSet(Gerrit.C.sectionActions());
keysAction.add(new NoOpKeyCommand(0, KeyCodes.KEY_ENTER, keysAction.add(new NoOpKeyCommand(0, KeyCodes.KEY_ENTER,

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchConstants.java
View File

@@ -49,6 +49,8 @@ public interface PatchConstants extends Constants {
String chunkNext2(); String chunkNext2();
String commentPrev(); String commentPrev();
String commentNext(); String commentNext();
String pagePrev();
String pageNext();
String fileList(); String fileList();
String expandComment(); String expandComment();
String expandAllCommentsOnCurrentLine(); String expandAllCommentsOnCurrentLine();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchConstants.properties
View File

@@ -31,6 +31,8 @@ chunkPrev2 = Previous diff chunk
chunkNext2 = Next diff chunk or search result chunkNext2 = Next diff chunk or search result
commentPrev = Previous comment commentPrev = Previous comment
commentNext = Next comment commentNext = Next comment
pagePrev = Page up
pageNext = Page down
fileList = Browse files in patch set fileList = Browse files in patch set
expandComment = Expand or collapse comment expandComment = Expand or collapse comment
expandAllCommentsOnCurrentLine = Expand or collapse all comments on current line expandAllCommentsOnCurrentLine = Expand or collapse all comments on current line