opendev/gerrit
Code Issues Proposed changes

Merge "Expect UUID of comment to be URL encoded when posting a review"

Browse Source
This commit is contained in:
Edwin Kempin
2013-02-27 06:25:27 +00:00
committed by Gerrit Code Review
parent 78ab514812 c09826d7f9
commit 4db4597a58
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/rest-api-changes.txt
View File

@@ -1323,7 +1323,8 @@ comment.
|===========================
|Field Name ||Description
|`id` |optional|
The UUID of the comment if an existing draft comment should be updated.
The URL encoded UUID of the comment if an existing draft comment should
be updated.
|`side` |optional|
The side on which the comment should be added. +
Allowed values are `REVISION` and `PARENT`. +

2
gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
View File

@@ -277,7 +277,7 @@ public class PostReview implements RestModifyView<RevisionResource, Input> {
String path = ent.getKey();
for (Comment c : ent.getValue()) {
String parent = Url.decode(c.inReplyTo);
PatchLineComment e = drafts.remove(c.id);
PatchLineComment e = drafts.remove(Url.decode(c.id));
boolean create = e == null;
if (create) {
e = new PatchLineComment(