opendev/gerrit
Code Issues Proposed changes

Rename EmailReviewCommentsExecutor to SendEmailExecutor

Browse Source 
The executor was already used to send email for other reason than
review comments. Rename it so it's more explicit that this executor can
be used to send any email asynchronously.

Change-Id: If5d5b59124bf44b4cbdda61536bfb50e8353285e
(cherry picked from commit d220a8ae57)
This commit is contained in:
Hugo Arès
2016-01-21 13:52:44 -05:00
parent 1ab66cc015
commit 4def41a04a
5 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/change/EmailReviewComments.java
View File

@@ -24,7 +24,7 @@ import com.google.gerrit.reviewdb.client.PatchLineComment;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.git.EmailReviewCommentsExecutor;
import com.google.gerrit.server.git.SendEmailExecutor;
import com.google.gerrit.server.mail.CommentSender;
import com.google.gerrit.server.patch.PatchSetInfoFactory;
import com.google.gerrit.server.util.RequestContext;
@@ -72,7 +72,7 @@ public class EmailReviewComments implements Runnable, RequestContext {
@Inject
EmailReviewComments (
@EmailReviewCommentsExecutor ExecutorService executor,
@SendEmailExecutor ExecutorService executor,
PatchSetInfoFactory patchSetInfoFactory,
CommentSender.Factory commentSenderFactory,
SchemaFactory<ReviewDb> schemaFactory,