opendev/gerrit
Code Issues Proposed changes

Disallow updates to group branches by direct push or submit

Browse Source 
While the migration of groups to NoteDb is not fully done yet we must
ensure that the group data in NoteDb stays in sync with the group data
in ReviewDb. This is why we must prevent updates to the NoteDb group
branches by direct push or by push for review + submit.

Change-Id: I9b9c43876755a1aa4c37204b0569529c37b0ad37
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-11-06 12:36:33 +01:00
parent c40a55128e
commit 4f742db3ec
6 changed files with 208 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/com/google/gerrit/acceptance/PushOneCommit.java
View File

@@ -313,16 +313,18 @@ public class PushOneCommit {
commitBuilder.message(subject).author(i).committer(new PersonIdent(i, testRepo.getDate()));
}
public void setParents(List<RevCommit> parents) throws Exception {
public PushOneCommit setParents(List<RevCommit> parents) throws Exception {
commitBuilder.noParents();
for (RevCommit p : parents) {
commitBuilder.parent(p);
}
return this;
}
public void setParent(RevCommit parent) throws Exception {
public PushOneCommit setParent(RevCommit parent) throws Exception {
commitBuilder.noParents();
commitBuilder.parent(parent);
return this;
}
public Result to(String ref) throws Exception {