opendev/gerrit
Code Issues Proposed changes

ReceiveCommits: provide banned commits to forReceiveCommits

Browse Source 
This lifts the banned commit loading out of the loop walking the
commits.

Change-Id: Ia27043f7223bc02b56d55e7c58170c07d65bf1e0
This commit is contained in:
Han-Wen Nienhuys
2018-09-04 11:42:05 +02:00
parent 218f1feb28
commit 4faeb9dd9e
2 changed files with 32 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/git/validators/CommitValidators.java
View File

@@ -45,7 +45,6 @@ import com.google.gerrit.server.config.AllUsersName;
import com.google.gerrit.server.config.CanonicalWebUrl;
import com.google.gerrit.server.config.GerritServerConfig;
import com.google.gerrit.server.events.CommitReceivedEvent;
import com.google.gerrit.server.git.BanCommit;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.git.ValidationError;
import com.google.gerrit.server.permissions.PermissionBackend;
@@ -127,11 +126,10 @@ public class CommitValidators {
Branch.NameKey branch,
IdentifiedUser user,
SshInfo sshInfo,
Repository repo,
NoteMap rejectCommits,
RevWalk rw,
@Nullable Change change)
throws IOException {
NoteMap rejectCommits = BanCommit.loadRejectCommitsMap(repo, rw);
ProjectState projectState = projectCache.checkedGet(branch.getParentKey());
return new CommitValidators(
ImmutableList.of(