opendev/gerrit
Code Issues Proposed changes

Move VersionedMetaData/MetaDataUpdate to their own package

Browse Source 
This change is one step in the long path of reducing the git package to
low-level utilities that build on top of JGit, with no or minimal
dependency on Gerrit internals. Those classes should be moved to move to
a package outside of server, such as com.google.gerrit.git, reducing the
size of our monster target.

VersionedMetaData is a candidate for such a low-level
non-Gerrit-specific package, but unfortunately MetaDataUpdate in its
current form is not: it depends on IdentifiedUser. Since
VersionedMetaData and MetaDataUpdate are just read/write views of the
same data, it makes sense to keep these classes together, in a package
under com.google.gerrit.server. In this change, we use the package
com.google.gerrit.server.git.meta; this is of course not set in stone,
but we would prefer to keep it at least in the medium term because this
rename affects a lot of files and downstream plugin callers.

Change-Id: Ic7d1521163bb35e232c6fe76d38a2793246b2117
This commit is contained in:
Dave Borowitz
2018-04-02 10:40:01 -04:00
parent faededc132
commit 4fb5341402
77 changed files with 94 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/server/account/AccountsUpdate.java
View File

@@ -34,7 +34,7 @@ import com.google.gerrit.server.config.AllUsersName;
import com.google.gerrit.server.extensions.events.GitReferenceUpdated;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.git.LockFailureException;
import com.google.gerrit.server.git.MetaDataUpdate;
import com.google.gerrit.server.git.meta.MetaDataUpdate;
import com.google.gerrit.server.index.change.ReindexAfterRefUpdate;
import com.google.gerrit.server.update.RefUpdateUtil;
import com.google.gerrit.server.update.RetryHelper;