opendev/gerrit
Code Issues Proposed changes

Merge "When an error is encountered during submit trigger app error state"

Browse Source
This commit is contained in:
Ole Rehmsen
2019-05-03 13:40:01 +00:00
committed by Gerrit Code Review
parent 224463a69e 90a2ffb1b5
commit 4fdaf8060d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
View File

@@ -756,6 +756,11 @@
return this.send(this._includeComments, this.canBeStarted) return this.send(this._includeComments, this.canBeStarted)
.then(keepReviewers => { .then(keepReviewers => {
this._purgeReviewersPendingRemove(false, keepReviewers); this._purgeReviewersPendingRemove(false, keepReviewers);
}).catch(err => {
this.dispatchEvent(new CustomEvent('show-error', {
bubbles: true,
detail: {message: `Error submitting review ${err}`},
}));
}); });
}, },