opendev/gerrit
Code Issues Proposed changes

ChangeScreen: Use submit type from ChangeInfo

Browse Source 
Avoids an extra request to /revisions/current/submit_type.

Change-Id: Iefc1531f3b2b64a8ecf58007d8f2e47df0771ca9
This commit is contained in:
Dave Borowitz
2015-12-17 13:21:11 -05:00
parent ace3210a62
commit 501db24756
2 changed files with 20 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java
View File

@@ -19,6 +19,7 @@ import com.google.gerrit.client.rpc.NativeString;
import com.google.gerrit.client.rpc.Natives;
import com.google.gerrit.common.data.LabelValue;
import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.extensions.client.SubmitType;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.Project;
@@ -139,6 +140,15 @@ public class ChangeInfo extends JavaScriptObject {
public final native boolean _more_changes()
/*-{ return this._more_changes ? true : false; }-*/;
public final SubmitType submitType() {
String submitType = _submitType();
if (submitType == null) {
return null;
}
return SubmitType.valueOf(submitType);
}
private final native String _submitType() /*-{ return this.submit_type; }-*/;
public final boolean submittable() {
init();
return _submittable();