Merge "Add support for 'base' in cherry pick dialog" into stable-2.16

This commit is contained in:
David Pursehouse
2019-02-21 23:29:39 +00:00
committed by Gerrit Code Review
4 changed files with 12 additions and 0 deletions

View File

@@ -1009,6 +1009,7 @@
true, true,
{ {
destination: el.branch, destination: el.branch,
base: el.baseCommit ? el.baseCommit : null,
message: el.message, message: el.message,
} }
); );

View File

@@ -595,6 +595,7 @@ limitations under the License.
assert.deepEqual(fireActionStub.lastCall.args, [ assert.deepEqual(fireActionStub.lastCall.args, [
'/cherrypick', action, true, { '/cherrypick', action, true, {
destination: 'master', destination: 'master',
base: null,
message: 'foo message', message: 'foo message',
}, },
]); ]);

View File

@@ -74,6 +74,15 @@ limitations under the License.
query="[[_query]]" query="[[_query]]"
placeholder="Destination branch"> placeholder="Destination branch">
</gr-autocomplete> </gr-autocomplete>
<label for="baseInput">
Provide base commit sha1 for cherry-pick
</label>
<input
is="iron-input"
id="baseCommitInput"
maxlength="40"
placeholder="(optional)"
bind-value="{{baseCommit}}">
<label for="messageInput"> <label for="messageInput">
Cherry Pick Commit Message Cherry Pick Commit Message
</label> </label>

View File

@@ -36,6 +36,7 @@
properties: { properties: {
branch: String, branch: String,
baseCommit: String,
changeStatus: String, changeStatus: String,
commitMessage: String, commitMessage: String,
commitNum: String, commitNum: String,