From 509be7b5d3ea23992ffb44df211f92939ecb41df Mon Sep 17 00:00:00 2001 From: Ole Rehmsen Date: Fri, 14 Sep 2018 16:20:06 +0200 Subject: [PATCH] Fix types of line Since we have compilation off, these are merely documentation, but that `number` through me off quite a bit - definitely worth fixing. Change-Id: Ic5ba1daeaad8c68ef3460ccb53f9f4ec6de0fcfa --- .../app/elements/diff/gr-diff-builder/gr-diff-builder.js | 2 +- polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js index 96a160e75e..60bf5ca367 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js @@ -353,7 +353,7 @@ }; /** - * @param {number} line + * @param {GrDiffLine} line * @param {string=} opt_side * @return {!Object} */ diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js index 978058f22b..44bb52a929 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js +++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js @@ -25,8 +25,10 @@ this.highlights = []; } + /** @type {number|string} */ GrDiffLine.prototype.afterNumber = 0; + /** @type {number|string} */ GrDiffLine.prototype.beforeNumber = 0; GrDiffLine.prototype.contextGroup = null;