opendev/gerrit
Code Issues Proposed changes

Fix types of line

Browse Source 
Since we have compilation off, these are merely documentation, but that
`number` through me off quite a bit - definitely worth fixing.

Change-Id: Ic5ba1daeaad8c68ef3460ccb53f9f4ec6de0fcfa
This commit is contained in:
Ole Rehmsen
2018-09-14 16:20:06 +02:00
parent 47032f3648
commit 509be7b5d3
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
View File

@@ -353,7 +353,7 @@
}; };
/** /**
* @param {number} line * @param {GrDiffLine} line
* @param {string=} opt_side * @param {string=} opt_side
* @return {!Object} * @return {!Object}
*/ */

2
polygerrit-ui/app/elements/diff/gr-diff/gr-diff-line.js
View File

@@ -25,8 +25,10 @@
this.highlights = []; this.highlights = [];
} }
/** @type {number|string} */
GrDiffLine.prototype.afterNumber = 0; GrDiffLine.prototype.afterNumber = 0;
/** @type {number|string} */
GrDiffLine.prototype.beforeNumber = 0; GrDiffLine.prototype.beforeNumber = 0;
GrDiffLine.prototype.contextGroup = null; GrDiffLine.prototype.contextGroup = null;