opendev/gerrit
Code Issues Proposed changes

Make SubmitRecord.Label's fields @Columns

Browse Source 
We want to serialize these label values into the secondary index so we
can avoid database lookups and submit rule evaluation when rendering
change tables. The easiest way to do this is to use Gerrit's protobuf
support to convert them to protos to store in the index. This is built
around @Column annotations, so use that.

Move to the reviewdb package to pick up the necessary gwtorm
dependency.

Change-Id: I02b4a14404a8d8d72452fea68f0c25f3cbb377f8
This commit is contained in:
Dave Borowitz
2013-09-10 14:53:53 -07:00
parent 1ecac16e29
commit 50a7a3a61d
16 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerJson.java
View File

@@ -22,10 +22,10 @@ import com.google.gerrit.common.data.LabelType;
import com.google.gerrit.common.data.LabelTypes;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.common.data.PermissionRange;
import com.google.gerrit.common.data.SubmitRecord;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.PatchSetApproval;
import com.google.gerrit.reviewdb.client.SubmitRecord;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.account.AccountInfo;
import com.google.gerrit.server.git.LabelNormalizer;