opendev/gerrit
Code Issues Proposed changes

Allow setting a comment message on a push

Browse Source 
Gerrit has a feature that allow setting labels, reviewers, and topic
on push[1] of a new change or patchset.  This adds an additional
'message' parameter to allow setting a comment message.

[1] https://gerrit-review.googlesource.com/Documentation/user-upload.html#push_create

Change-Id: I9e242e4de2892723a0eb03c8a3b7fe3c574058ac
Feature: Issue 4015
This commit is contained in:
Khai Do
2016-03-30 16:50:13 -07:00
committed by Saša Živkov
parent eedd8a3b9b
commit 50eb94e4b2
5 changed files with 80 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/AbstractPushForReview.java
View File

@@ -34,6 +34,7 @@ import com.google.gerrit.extensions.api.changes.ReviewInput;
import com.google.gerrit.extensions.api.changes.ReviewInput.NotifyHandling;
import com.google.gerrit.extensions.client.InheritableBoolean;
import com.google.gerrit.extensions.common.ChangeInfo;
import com.google.gerrit.extensions.common.ChangeMessageInfo;
import com.google.gerrit.extensions.common.EditInfo;
import com.google.gerrit.extensions.common.LabelInfo;
import com.google.gerrit.reviewdb.client.AccountGroup;
@@ -51,6 +52,7 @@ import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import java.util.Collection;
import java.util.Set;
public abstract class AbstractPushForReview extends AbstractDaemonTest {
@@ -236,6 +238,20 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest {
assertThat(edit).isNotNull();
}
@Test
public void testPushForMasterWithMessage() throws Exception {
PushOneCommit.Result r = pushTo("refs/for/master/%m=my_test_message");
r.assertOkStatus();
r.assertChange(Change.Status.NEW, null);
ChangeInfo ci = get(r.getChangeId());
Collection<ChangeMessageInfo> changeMessages = ci.messages;
assertThat(changeMessages).hasSize(1);
for (ChangeMessageInfo cm : changeMessages) {
assertThat(cm.message).isEqualTo(
"Uploaded patch set 1.\nmy test message");
}
}
@Test
public void testPushForMasterWithApprovals() throws Exception {
PushOneCommit.Result r = pushTo("refs/for/master/%l=Code-Review");