From a111bbc62a08b90602b9505672060248121ddeb4 Mon Sep 17 00:00:00 2001 From: Sebastian Schuberth Date: Wed, 16 Nov 2016 16:37:04 +0100 Subject: [PATCH] Remove an obsolete code comment from the AsciiDoctor class In case of the bazel build no Zip file for the HTML documentation is created. Instead, we want keep the individual HTML files. With that in mind it is no longer true that we would like to render HTML to a string that gets directly added as a ZipEntry, so remove that comment. Change-Id: I8384c8500e3658aebd6143fbe766cf1944bb4809 --- lib/asciidoctor/java/AsciiDoctor.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/asciidoctor/java/AsciiDoctor.java b/lib/asciidoctor/java/AsciiDoctor.java index 1871b0c324..13b72d1f02 100644 --- a/lib/asciidoctor/java/AsciiDoctor.java +++ b/lib/asciidoctor/java/AsciiDoctor.java @@ -108,10 +108,6 @@ public class AsciiDoctor { .eruby(ERUBY) .safe(SafeMode.UNSAFE) .baseDir(base) - // XXX(fishywang): ideally we should just output to a string and add the - // content into zip. But asciidoctor will actually ignore all attributes - // if not output to a file. So we *have* to output to a file then read - // the content of the file into zip. .toFile(outputFile); AttributesBuilder attributesBuilder = AttributesBuilder.attributes();