opendev/gerrit
Code Issues Proposed changes

Remove useless calls to autoReindexIfStale

Browse Source 
These calls are already made from the #index method, where the long
comment lives. As such, it is safe (and best) to remove them.

Before this change, autoReindexIfStale was called twice per change to be
reindexed.

Change-Id: Ifd7c6bed9f78f48e62336975fa5ebe6d36d6eccc
This commit is contained in:
Maxime Guerreiro
2018-06-05 09:26:46 +00:00
parent c3eeb8634f
commit 517c1f651a
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/server/index/change/ChangeIndexer.java
View File

@@ -243,8 +243,6 @@ public class ChangeIndexer {
*/
public void index(ReviewDb db, Change change) throws IOException, OrmException {
index(newChangeData(db, change));
// See comment in #index(ChangeData).
autoReindexIfStale(change.getProject(), change.getId());
}
/**
@@ -256,10 +254,7 @@ public class ChangeIndexer {
*/
public void index(ReviewDb db, Project.NameKey project, Change.Id changeId)
throws IOException, OrmException {
ChangeData cd = newChangeData(db, project, changeId);
index(cd);
// See comment in #index(ChangeData).
autoReindexIfStale(cd);
index(newChangeData(db, project, changeId));
}
/**