opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/replication from branch 'master'
  to 32f7c91a3d905d891b7bec9d44bf274718351d5e
  - Fix StackOverflow caused by infinite method recursion
    
    Commit e092bbf83c5056fd02619d722b766882f44e982b changed the method
    signature of `shouldReplicate(ProjectControl)` to
    `shouldReplicate(ProjectState, CurrentUser)`.
    
    The thread scoper callable now calls `shouldReplicate(Project.NameKey)`
    which matches with
    `shouldReplicate(Project.NameKey, ReplicationState...)`,
    resulting in an infinite recursion.
    
    Caused by: java.lang.StackOverflowError
    	at com.google.gerrit.server.util.ThreadLocalRequestContext.getContext(ThreadLocalRequestContext.java:87)
    	at com.google.gerrit.server.util.ThreadLocalRequestContext.setContext(ThreadLocalRequestContext.java:80)
    	at com.google.gerrit.server.util.RequestScopePropagator.lambda$context$0(RequestScopePropagator.java:178)
    	at com.google.gerrit.server.git.PerThreadRequestScope$Propagator.lambda$scope$0(PerThreadRequestScope.java:73)
    	at com.googlesource.gerrit.plugins.replication.Destination.shouldReplicate(Destination.java:301)
    	at com.googlesource.gerrit.plugins.replication.Destination.access$500(Destination.java:81)
    	at com.googlesource.gerrit.plugins.replication.Destination$3.call(Destination.java:298)
    	at com.googlesource.gerrit.plugins.replication.Destination$3.call(Destination.java:295)
            ......
    
    Change-Id: Ib8358a9f2b96031e8d63536c7c191ba9783570ef
    Signed-off-by: Alexander Martinz <alex@amartinz.at>
This commit is contained in:
Alexander Martinz 2017-11-01 22:30:12 +01:00 committed by Gerrit Code Review
parent caf37247cd
commit 522b668a87
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/replication

@ -1 +1 @@
Subproject commit 196d05773af4931cc7deed8510826d195e7fc544
Subproject commit 32f7c91a3d905d891b7bec9d44bf274718351d5e