opendev/gerrit
Code Issues Proposed changes

ChangeNotes: Don't @Inject constructor

Browse Source 
This is always constructed through a manual factory, and there is no
way @Injecting a Change would work.

Change-Id: I12c346d9c1ce40c3b713ab34dde649dd71b8e30d
This commit is contained in:
Dave Borowitz
2014-09-08 17:45:05 +02:00
parent b966745845
commit 523807681d
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ChangeNotes.java
View File

@@ -139,7 +139,6 @@ public class ChangeNotes extends AbstractChangeNotes<ChangeNotes> {
private final AllUsersName allUsers; private final AllUsersName allUsers;
private DraftCommentNotes draftCommentNotes; private DraftCommentNotes draftCommentNotes;
@Inject
@VisibleForTesting @VisibleForTesting
public ChangeNotes(GitRepositoryManager repoManager, public ChangeNotes(GitRepositoryManager repoManager,
AllUsersNameProvider allUsersProvider, Change change) { AllUsersNameProvider allUsersProvider, Change change) {