opendev/gerrit
Code Issues Proposed changes

Make hyperlinks update URL when screen is visible

Browse Source 
Instead of updating the URL to the screen and then loading the RPCs,
update the URL after the RPCs are complete and the screen is going
to be made visible to the user.  This allows us to behave similar
to the way Gmail reacts, which is to avoid the URL update until the
data you are viewing matches the URL.

Change-Id: Iadde8240d506e3a51b9f064ecfa5fb91045616f5
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-12-30 09:33:11 -08:00
parent 08ba0c6817
commit 53eae8cdd3
32 changed files with 303 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/ScreenLoadCallback.java
View File

@@ -43,7 +43,7 @@ public abstract class ScreenLoadCallback<T> extends GerritCallback<T> {
@Override
public void onFailure(final Throwable caught) {
if (isNoSuchEntity(caught)) {
Gerrit.display(new NotFoundScreen());
Gerrit.display(screen.getToken(), new NotFoundScreen());
} else {
super.onFailure(caught);
}