opendev/gerrit
Code Issues Proposed changes

Surround <input is="iron-input"> with <iron-input>

Browse Source 
Type extension does not work anymore in Polymer 2:
https://polymer-library.polymer-project.org/2.0/docs/about_20#type-extension

Recommendation by Polyer expert was:
Most of the time, you can do
<iron-input params...>
  <input is="iron-input" thoseSameParams...>
</iron-input>

id attributes were kept at the <input> element, not moved to the
<iron-input> element. This may mean that in Polymer 2 some still tests
are still failing that look up input elements by id. Will fix this in
a follow-up change.

The goal was to create a simple non-breaking change across the entire
code base. There might still be some issues running this with Polymer 2.

This change also clean ups iron-input html imports. Some could be
removed, some had to be added.

Change-Id: I48361ff465990246622ec8ad23d80b75f40cc055
This commit is contained in:
Ben Rohlfs
2019-06-17 12:45:45 +02:00
parent 1066c58c28
commit 540a5fe0bb
35 changed files with 319 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/documentation/gr-documentation-search/gr-documentation-search.html
View File

@@ -18,7 +18,6 @@ limitations under the License.
<link rel="import" href="../../../behaviors/base-url-behavior/base-url-behavior.html">
<link rel="import" href="../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.html">
<link rel="import" href="/bower_components/iron-input/iron-input.html">
<link rel="import" href="../../../styles/gr-table-styles.html">
<link rel="import" href="../../../styles/shared-styles.html">
<link rel="import" href="../../shared/gr-list-view/gr-list-view.html">